Repository navigation
(PA-8998) Require a puppet9 master for the puppet8->9 upgrade test - #847
Merged
Merged
Conversation
span786
marked this pull request as ready for review
August 6, 2026 14:25
puppetserver 9-nightly builds are now available (confirmed against artifactory for el-9-x86_64, our master platform), so tighten require_master_collection from 'min: puppet8' to 'min: puppet9' to properly exercise the upgrade against a real puppet9 master instead of falling back to a puppet8 one. Also updates the now-stale Rakefile comment describing UPGRADE_TARGET_COLLECTION, which cited the same "puppetserver-9 nightlies aren't yet published" rationale. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
span786
force-pushed
the
PA-8998-require-puppet9-master
branch
from
August 17, 2026 05:41
6ef9164 to
e859d9f
Compare
joshcooper
reviewed
Aug 17, 2026
joshcooper
left a comment
joshcooper
left a comment
Contributor
There was a problem hiding this comment.
Requiring puppetserver 9 makes sense, but the end result is we're skipping the upgrade test:
01:39:37 glutamic-mentor.delivery.puppetlabs.net (glutamic-mentor.delivery.puppetlabs.net) 08:39:37$ puppetserver --version
...
01:39:37 puppetserver version: 8.9.11.SNAPSHOT.2026.08.10T1822
01:39:37
01:39:37 glutamic-mentor.delivery.puppetlabs.net (glutamic-mentor.delivery.puppetlabs.net) executed in 0.37 seconds
01:39:37
01:39:37 This master is set up with a puppetserver from the puppet8 collection. This test requires a puppetserver from the puppet9 collection or newer. Skipping the test ...
I'm thinking the pipeline needs to provision a puppet 9 stack to start with? Or will that be handled in a separate PR?
Contributor
Author
|
This change required a change in the Pipeline as well, I opened a ci-job-configs PR https://github.com/puppetlabs/ci-job-configs/pull/10806 |
joshcooper
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_upgrade_puppet8_to_puppet9.rbusedrequire_master_collection min: 'puppet8'because puppet9-nightly puppetserver builds weren't reliably published yet, so the test accepted a puppet8-or-newer master while agents were upgraded to puppet9.puppetserver9-nightlyis published forel/9/x86_64(our master's platform).require_master_collection min: 'puppet9'so the test properly exercises the upgrade against a real puppet9 master instead of silently falling back to puppet8.UPGRADE_TARGET_COLLECTIONcomment, which cited the same now-stale "puppetserver-9 nightlies aren't yet published" rationale.hosts.yamlever changes.Test plan
puppetserver9-nightlyexists for el-9-x86_64 (current master platform) on artifactoryruby -csyntax checktest_upgrade_puppet8_to_puppet9.rbacceptance run withMASTER_COLLECTION=puppet9-nightly