Repository navigation
Revert dnf5 upgrade-test diagnostics added in #851 - #853
Merged
Merged
Conversation
The diagnostics (repo/package state dump on a post-upgrade version mismatch) were added to help investigate PA-9119/PUP-12151's Fedora 41 dnf5 failure. The actual root cause has since been diagnosed and fixed in puppet-private (a Yum.parse_updates parsing bug, see puppetlabs/puppet-private#220); these extra diagnostic lines aren't needed in the test going forward. Reverts only the acceptance/tests/test_upgrade_puppet8_to_puppet9.rb diagnostics hunk from #851 -- leaves that PR's unrelated manifests/install.pp versioncmp() truthiness fix and its regression test in spec/classes/puppet_agent_spec.rb in place, since that's a separate, valid bug fix.
joshcooper
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts the acceptance-test diagnostics added in #851 to
acceptance/tests/test_upgrade_puppet8_to_puppet9.rb(the repo/package state dump —dnf repolist,dnf list --showduplicates, etc. — logged on a post-upgrade version-assertion failure).Those diagnostics were added to help investigate the Fedora 41 dnf5 upgrade failure (PA-9119/PUP-12151). The actual root cause has since been diagnosed and fixed at the source in puppet-private (a
Yum.parse_updatestext-parsing bug — dnf5'scheck-update/listoutput interleaves a progress preamble with the package list without a blank-line separator, and the old parser's block-flattening approach silently misaligned and dropped every update entry as a result). See puppetlabs/puppet-private#220. These diagnostic lines aren't needed in the test going forward.Scope note: #851 also included an unrelated, valid bug fix (
manifests/install.pp'sversioncmp()truthiness bug, plus its regression test inspec/classes/puppet_agent_spec.rb). This PR reverts only the test-diagnostics hunk — theinstall.ppfix and its test are untouched, since that's a separate legitimate fix, not diagnostic scaffolding.Test plan
git diffagainst (PA-9119) Diagnose dnf5 metadata staleness and fix versioncmp() truthiness bug #851's pre-merge parent confirmstest_upgrade_puppet8_to_puppet9.rbis now byte-identical to its pre-(PA-9119) Diagnose dnf5 metadata staleness and fix versioncmp() truthiness bug #851 statebundle exec rubocop acceptance/tests/test_upgrade_puppet8_to_puppet9.rb— no offensesmanifests/install.ppandspec/classes/puppet_agent_spec.rbare untouched by this PR🤖 Generated with Claude Code