Conversation
iplot() and coefplot() ignored labels unless cat_template was set, and emitted one DeprecationWarning per coefficient. cat_template had no effect on i() names and is now deprecated.
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Member
|
Hi @anevolbap, thanks so much for the PR! Is it ready for a review from my side? It seems so at a first glimpse =) |
anevolbap
marked this pull request as ready for review
September 15, 2026 22:09
Author
Now it is, thanks! |
…deprecations # Conflicts: # docs/changelog.qmd
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Finishes the deprecation of the relabel helpers in
pyfixest/report/utils.py(#1123). Each warning now names the function that was called (all said_relabel_expvarbefore), and_check_label_keys_in_covarswarns too.iplot()andcoefplot()no longer call these helpers. On master both ignoredlabelsunlesscat_templatewas set, and emitted oneDeprecationWarningper coefficient.labelsnow matches full coefficient names or each variable of an interaction term, without splittingvariable::valuenames.iplot(cat_template=...)is deprecated:i()coefficients are already namedvariable::value, so the template never matched. Docs examples dropcat_templateandrename_event_study_coefs(), which had no effect on these plots.Verification
Passed on 393a866 (master merged in):
pixi run -e py312 test-py(5792 passed, 336 s);pytest tests/test_plots.py tests/test_visualize.py tests/test_decomposition.pywith extended tests (869 passed, 210 s);pixi run ty;prek runruff-format and ruff-check on changed files;git diff --check. The new tests fail on master.Deferred to exact-head CI (
ci-tests.yaml, waiting for workflow approval):tests/test_did.py, which needs rpy2 and is not in the local py312 env, anddocs-renderfor the changediplotdocstring and docs pages.🤖 Generated with Claude Code