test: pin the #286 akm_slopes cell against fake convergence - #397
Merged
Merged
Conversation
The shared_year cell (100k rows, mobility 0.05, tol 1e-12) once drove the Schwarz factor near singular, and the collapsed LSMR recurrences reported it converged at a group-mean error of 18 (#290, #276 wheel). Solved single-threaded, where the collapse reproduces, it must converge with every group mean of the demeaned response below 1e-6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 4/7 (test), based on main. Lands the #286/#290 regression cell before the exit rework in #388, so the rework visibly keeps it green.
tests/test_fake_convergence.pysolves the akm_slopes shared_year cell (100k rows, mobility 0.05, tol 1e-12) single-threaded, where the recurrence collapse reproduces, and requiresconvergedwith every group mean of the demeaned response below 1e-6.