Normalize Windows drive letter case in workspace document URIs - #719
Open
Sanjays2402 wants to merge 1 commit into
Open
Normalize Windows drive letter case in workspace document URIs#719Sanjays2402 wants to merge 1 commit into
Sanjays2402 wants to merge 1 commit into
Conversation
Windows drive letters are case-insensitive and clients may send either `file:///C:/foo` (RFC 8089) or `file:///c:/foo` for the same file. `uris.from_fs_path` lower-cases the drive letter, but `Workspace._docs` stored URIs verbatim, so the two spellings became distinct dictionary keys. A document opened under one spelling was then invisible under the other, and lookups silently fell back to reading stale content from disk instead of the in-memory version. Add `uris.normalize` and use it for every `_docs` key, so a document is found regardless of the drive letter case the client used. Non-drive paths are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #697
Windows drive letters are case-insensitive, so a client may send
file:///C:/foo(RFC 8089) orfile:///c:/foofor the same file.uris.from_fs_pathlower-cases the drive letter butWorkspace._docsstored URIs verbatim, so the two spellings became separate dictionary keys — a document opened under one spelling was invisible under the other, and lookups silently fell back to stale on-disk content instead of the in-memory version.Adds
uris.normalizeand uses it for every_docskey. Non-drive paths are unchanged. New tests fail without the fix and pass with it.