docs(proposals): Deprecate PEP 508 Direct References (req.url)#1225
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis change adds an architecture decision record proposing deprecation and eventual removal of PEP 508 direct-reference URL ( Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This aligns with what we discussed earlier today. @dhellmann originally added this feature and we should wait for him to take a look and see what he thinks. |
|
Nit-pick: We don't use the term "ADR" in upstream Fromager. |
3e4eda9 to
4f97bed
Compare
|
I like this idea. This gives us an opportunity to cleanup the code |
…(req.url) Propose deprecating the `package @ git+https://...` syntax in favor of the declarative `source` provider config. The feature requires 19 special-case branches across 6 files and every use case is covered by the new git-clone providers (pypi-git, github-tag-git, gitlab-tag-git, versionmap-git). Co-Authored-By: Claude <claude@anthropic.com> Signed-off-by: Shanmukh Pawan <smoparth@redhat.com>
4f97bed to
6185f32
Compare
|
Tick the box to add this pull request to the merge queue (same as
|
Propose deprecating the
package @ git+https://...syntax in favor of the declarativesourceprovider config. The feature requires 19 special-case branches across 6 files and every use case is covered by the new git-clone providers (pypi-git, github-tag-git, gitlab-tag-git, versionmap-git).Pull Request Description
What
Why