Skip to content

docs(proposals): Deprecate PEP 508 Direct References (req.url)#1225

Merged
LalatenduMohanty merged 1 commit into
mainfrom
docs/deprecate-req-url
Jul 16, 2026
Merged

docs(proposals): Deprecate PEP 508 Direct References (req.url)#1225
LalatenduMohanty merged 1 commit into
mainfrom
docs/deprecate-req-url

Conversation

@smoparth

@smoparth smoparth commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Propose deprecating the package @ git+https://... syntax in favor of the declarative source provider config. The feature requires 19 special-case branches across 6 files and every use case is covered by the new git-clone providers (pypi-git, github-tag-git, gitlab-tag-git, versionmap-git).

Pull Request Description

What

Why

@smoparth smoparth requested a review from a team as a code owner July 2, 2026 14:57
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9718375a-568f-4e36-b9a0-b7ef0f831cd8

📥 Commits

Reviewing files that changed from the base of the PR and between 4f97bed and 6185f32.

📒 Files selected for processing (1)
  • docs/proposals/deprecate-req-url.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • docs/proposals/deprecate-req-url.md

📝 Walkthrough

Walkthrough

This change adds an architecture decision record proposing deprecation and eventual removal of PEP 508 direct-reference URL (req.url) support for top-level bootstrap inputs. It defines scope limits, maps use cases to declarative source provider configuration, and outlines phases for warnings, migration guidance, and removal of special-case code paths. No code or public API changes are included.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the proposal to deprecate PEP 508 direct references via req.url.
Description check ✅ Passed The description is directly related to the change and explains the deprecation motivation and replacement providers.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rd4398

rd4398 commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

This aligns with what we discussed earlier today. @dhellmann originally added this feature and we should wait for him to take a look and see what he thinks.

@rd4398 rd4398 requested a review from dhellmann July 2, 2026 15:07
@tiran

tiran commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Nit-pick: We don't use the term "ADR" in upstream Fromager.

@smoparth smoparth force-pushed the docs/deprecate-req-url branch from 3e4eda9 to 4f97bed Compare July 6, 2026 14:42
@smoparth smoparth changed the title docs(proposals): add ADR to deprecate PEP 508 direct references (req.url) docs(proposals): Deprecate PEP 508 Direct References (req.url) Jul 6, 2026
@LalatenduMohanty

Copy link
Copy Markdown
Member

I like this idea. This gives us an opportunity to cleanup the code

Comment thread docs/proposals/deprecate-req-url.md Outdated
Comment thread docs/proposals/deprecate-req-url.md
Comment thread docs/proposals/deprecate-req-url.md Outdated
…(req.url)

Propose deprecating the `package @ git+https://...` syntax in favor
of the declarative `source` provider config. The feature requires 19
special-case branches across 6 files and every use case is covered by
the new git-clone providers (pypi-git, github-tag-git, gitlab-tag-git,
versionmap-git).

Co-Authored-By: Claude <claude@anthropic.com>
Signed-off-by: Shanmukh Pawan <smoparth@redhat.com>

@rd4398 rd4398 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify

mergify Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@LalatenduMohanty LalatenduMohanty merged commit dc64ee2 into main Jul 16, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants