gh-153840: Escape special characters in flamegraph function names - #153841
Open
tonghuaroot wants to merge 4 commits into
Open
gh-153840: Escape special characters in flamegraph function names#153841tonghuaroot wants to merge 4 commits into
tonghuaroot wants to merge 4 commits into
Conversation
Contributor
|
Looks ok. Can you add tests? |
Contributor
Author
|
Added a test that verifies |
eendebakpt
reviewed
Jul 31, 2026
| idx = content.find("EMBEDDED_DATA") | ||
| if idx != -1: | ||
| after_embed = content[idx:] | ||
| self.assertNotIn("</script><b>", after_embed.split("</script>")[0]) |
Contributor
There was a problem hiding this comment.
Does this test anything? After the split we have stripped the </script> part.
Contributor
Author
There was a problem hiding this comment.
The split hid it. Rewritten to assert the escaped \u003c/script\u003e is present and the raw </script><b> absent.
A single-frame stack yields an empty export, so the escaping was never exercised. Assert the export succeeded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Escape
<,>,&as<etc. in the embedded JSON blob to prevent</script>breakout, and wrap the tooltip function name with the existingescapeHtml()helper. The sibling heatmap exporter and the flamegraph's owndisplayNamealready escape; the function name was missed.