Repository navigation
BUG: Fix bugs related to uneven columns and invalid args in trim metadata - #86
Merged
Merged
Conversation
Oddant1
changed the title
colinvwood
reviewed
Sep 29, 2026
Comment on lines
+209
to
+210
| column_adapters = \ | ||
| metadata.get_column(column).to_series().dropna().tolist() |
Contributor
There was a problem hiding this comment.
I wonder if it would be better to use the metadata API to drop missing values here. In the rare chance that someone was using a different missing scheme and didn't want those passed on.
Contributor
There was a problem hiding this comment.
Actually, I was wrong we would need to have passed encode_missing=True for that to have happened. So is fine as is.
Contributor
There was a problem hiding this comment.
This should be called decode_missing really
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When I was calling the cutadapt trim actions from a different plugin, Claude identified the following bugs
Uneven columns cause an error e.g., providing two rows for
front_fbut only one forfront_rcauses aNaNto be passed in as a second value forfront_rcausing an error.If we are parsing args for
trim_singleand find paired only args, we drop those args with a warning, but this only occurs if the args have an _ name e.g.front_r. We allowfront-rto be used as an arg, so we should warn if it is passed in when invalid.AI Disclosure
AI Usage Details
Bugs identified and fixed by Claude