Repository navigation
Conversation
| target_link_libraries(quickshell-window PRIVATE | ||
| Qt::Core Qt::Gui Qt::Quick Qt6::QuickPrivate | ||
| Qt::Core Qt::Gui Qt::Quick Qt6::QuickPrivate quickshell-core | ||
| ) |
There was a problem hiding this comment.
Would rather avoid since this slows compile. qs_add_module_deps_light is generally supposed to accomplish the same things for qml types.
| struct WindowMarginsForeign { | ||
| Q_GADGET; | ||
| QML_FOREIGN(Margins); | ||
| QML_ANONYMOUS; | ||
| }; | ||
|
|
There was a problem hiding this comment.
Probably shouldnt be required since we have control of the original type
72a1ce2 to
11ca60b
Compare
8ffc24f to
8d8659f
Compare
declare the bluetooth dependency and use the registered polkit type name let the window module read margins directly without linking all of core
8d8659f to
1f33342
Compare
|
@outfoxxed thanks for the review just for more context: i thought keeping it separate because adding all of types.hpp to the window target would also register unrelated types like Box and Edges there otherwise this gets rid of both the hard core link and the foreign wrapper the main Quickshell module already default imports |
2 participants
fixes #1037
these warnings came from three missing links in the generated type info
bluetooth returns an object model from the main quickshell module so its qmldir
needs to list that module as a dependency
polkit stores authflow under its full c++ name so the flow property needs to use
the same name
panelwindow gets margins from the core module so the window target needs the
core metadata too
the anonymous margins entry then gives qmllint the left right top andbottom properties in the module where panelwindow uses them
i built the bluetooth polkit and window targets and ran example from the issue against the "generated" qml modules