Repository navigation
Conversation
onSocketError emits error() before cleaning up. If a handler responds by setting connected = false, disconnectFromServer() emits disconnected() synchronously and onSocketDisconnected() deletes the socket and nulls the pointer. onSocketError then sees !connected and calls deleteLater() on nullptr, which segfaults. This happens whenever the peer of a QML Socket with `onError: connected = false` goes away, e.g. restarting the daemon on the other end. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
outfoxxed
force-pushed
the
master
branch
2 times, most recently
from
October 22, 2026 06:48
bf6302e to
9b0f339
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onSocketError emits error() before cleaning up. If a handler responds by setting connected = false, disconnectFromServer() emits disconnected() synchronously and onSocketDisconnected() deletes the socket and nulls the pointer. onSocketError then sees !connected and calls deleteLater() on nullptr, which segfaults.
This happens whenever the peer of a QML Socket with
onError: connected = falsegoes away, e.g. restarting the daemon on the other end.Describe your changes
Details and descisions
Open concerns
Participation