Skip to content

asynq: use py3 generator throws - #166

Merged
994125010 merged 1 commit into
masterfrom
asyncio-mock
Nov 18, 2025
Merged

994125010 merged 1 commit into
masterfrom
asyncio-mock

Conversation

@994125010

Copy link
Copy Markdown
Contributor

the asyncio stuff is py3 so also do this

Reviewers: hwanseung

Test Plan: unit tests still work

Addresses Pull Requests:

Differential Revision:

Asana Tasks:

Screenshot:

CC:

Deploy To:

the asyncio stuff is py3 so also do this

Reviewers: hwanseung

Test Plan: unit tests still work

Addresses Pull Requests:

Differential Revision:

Asana Tasks:

Screenshot:

CC:

Deploy To:

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes the generator.throw() call in the convert_asynq_to_async function to use Python 3's simplified single-argument syntax instead of the legacy three-argument form.

  • Simplified generator.throw() from three arguments to single argument form

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@HwanSeungYeo HwanSeungYeo left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this! It looks good to me.

To provide more context, this is to address the following warning messge.

DeprecationWarning: the (type, exc, tb) signature of throw() is deprecated, use the single-arg signature instead.

@994125010
994125010 merged commit 46b72a1 into master Nov 18, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants