fix(sys): Enforce CGo safety rules in WinTrust API calls#712
Open
rabbitstack wants to merge 1 commit into
Open
fix(sys): Enforce CGo safety rules in WinTrust API calls#712rabbitstack wants to merge 1 commit into
WinTrust API calls#712rabbitstack wants to merge 1 commit into
Conversation
Every single Wintrust struct field is converting a Go pointer to uintptr and storing it. This is the exact pattern the Go spec explicitly calls out as unsafe. The moment the uintptr value is stored, the GC no longer considers the original object reachable through it and is free to collect or move it before WinVerifyTrust reads the field. The KeepAlive calls must come after verifyTrust() returns, not before. Their purpose is to extend the liveness of each object to that point. As an additional improvement, handle CryptCatalogAdminCalcHashFromFileHandle error code and resize the has buffer with the new size if the call fails with ERROR_INSUFFICIENT_BUFFER.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR / why it is needed?
Every single Wintrust struct field is converting a Go pointer to uintptr and storing it. This is the exact pattern the Go spec explicitly calls out as unsafe. The moment the uintptr value is stored, the GC no longer considers the original object reachable through it and is free to collect or move it before WinVerifyTrust reads the field.
The KeepAlive calls must come after verifyTrust() returns, not before. Their purpose is to extend the liveness of each object to that point.
As an additional improvement, handle
CryptCatalogAdminCalcHashFromFileHandleerror code and resize the hash buffer with the new size if the call fails withERROR_INSUFFICIENT_BUFFER.What type of change does this PR introduce?
/kind bug-fix (non-breaking change which fixes an issue)
Any specific area of the project related to this PR?
/area telemetry
Special notes for the reviewer
Does this PR introduce a user-facing change?