Skip to content

Remove unused projects pagination code - #1707

Merged
MyPyDavid merged 1 commit into
2.5.2/releasefrom
2.5.2/fix/clean-up-projects-pagination-template
Aug 13, 2026
Merged

MyPyDavid merged 1 commit into
2.5.2/releasefrom
2.5.2/fix/clean-up-projects-pagination-template

Conversation

@MyPyDavid

Copy link
Copy Markdown
Member

Removes rdmo/projects/templates/projects/projects_pagination.html and the set_context_querystring_with_filter_and_page util function.

Otherwise we could have used the new {% querystring %} templatetag from https://docs.djangoproject.com/en/5.2/releases/5.1/#what-s-new-in-django-5-1 for the pagination.

Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
@MyPyDavid MyPyDavid self-assigned this Aug 7, 2026
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage is 95.156% — 2.5.2/fix/clean-up-projects-pagination-template into 2.5.2/release. No base build found for 2.5.2/release.

@MyPyDavid

Copy link
Copy Markdown
Member Author

we can merge it now in 2.5.2 (it only deletes files/code).
However it will also be relevant for the big rebase and cleanup for 3.0.0 https://github.com/rdmorganiser/rdmo/milestone/25, eg. in #1582 .

@MyPyDavid MyPyDavid added this to the RDMO 2.5.2 milestone Aug 13, 2026
@MyPyDavid
MyPyDavid merged commit 67af417 into 2.5.2/release Aug 13, 2026
20 checks passed
@MyPyDavid
MyPyDavid deleted the 2.5.2/fix/clean-up-projects-pagination-template branch August 13, 2026 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants