fix: consider extralight fonts in RCTGetFontWeight - #57775
Draft
vonovak wants to merge 1 commit into
Draft
Conversation
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
RCTGetFontWeight, as the name suggests, gets a UIFontWeight given the font names. Some font names are calledextralightwhich is the same weight as the already-coveredultralight -> UIFontWeightUltraLightcase.However, they'd incorrectly be classified as
UIFontWeightLight. This PR fixes that. Note that theextraboldcase was already covered.Changelog:
[iOS] [FIXED] - correctly classify extralight fonts as
UIFontWeightUltraLightinRCTGetFontWeightTest Plan: