Enable Perfetto by default for Android dev builds - #57779
Open
javache wants to merge 1 commit into
Open
Conversation
Summary: Perfetto tracing in `reactperflogger` previously required an explicit build modifier to turn on, so ordinary Android development builds never had it. Introduce a shared `if_perfetto(on, off)` helper (`reactperflogger/DEFS.bzl`) that derives the Perfetto decision from build configuration: on by default for non-optimized Android builds, while optimized builds still require the explicit `perfetto` constraint so tracing stays out of release binaries. arvr/Horizon builds are excluded via `hz_tracing:perfetto-enable` — the same signal reactperflogger already keys on — because those builds manage Perfetto through their own `hz_tracing` stack (resolved at the final binary), so a standalone RN `.so` compiling `WITH_PERFETTO` there fails to link. The Android `BuildConfig.ENABLE_PERFETTO` runtime gate and the other native Perfetto consumers are routed through the same helper so the default is consistent end-to-end. The now-orphaned `enable_perfetto` config_setting is removed. Changelog: [Internal] Differential Revision: D114210766
meta-cla
Bot
added
the
CLA Signed
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D114210766. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Perfetto tracing in
reactperfloggerpreviously required an explicit buildmodifier to turn on, so ordinary Android development builds never had it.
Introduce a shared
if_perfetto(on, off)helper (reactperflogger/DEFS.bzl)that derives the Perfetto decision from build configuration: on by default for
non-optimized Android builds, while optimized builds still require the explicit
perfettoconstraint so tracing stays out of release binaries. arvr/Horizonbuilds are excluded via
hz_tracing:perfetto-enable— the same signalreactperflogger already keys on — because those builds manage Perfetto through
their own
hz_tracingstack (resolved at the final binary), so a standalone RN.socompilingWITH_PERFETTOthere fails to link.The Android
BuildConfig.ENABLE_PERFETTOruntime gate and the other nativePerfetto consumers are routed through the same helper so the default is
consistent end-to-end. The now-orphaned
enable_perfettoconfig_setting isremoved.
Changelog:
[Internal]
Differential Revision: D114210766