Skip to content

DFBUGS-9260: replace golang.org/x/net with the sustaining fork - #803

Open
ttrishag wants to merge 1 commit into
red-hat-storage:release-4.14from
ttrishag:DFBUGS-9260
Open

ttrishag wants to merge 1 commit into
red-hat-storage:release-4.14from
ttrishag:DFBUGS-9260

Conversation

@ttrishag

@ttrishag ttrishag commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

https://redhat.atlassian.net/browse/RHSTOR-9714

Summary

  • Replace golang.org/x/net with github.com/openshift-sustaining/net v0.35.0-sec.3 for DFBUGS-9260, and bump golang.org/x/sys, golang.org/x/term, and golang.org/x/text to match.
  • Download Kubernetes 1.28.3 envtest binaries from the controller-tools GitHub release. The old kubebuilder-tools bucket returns an error page, which tar then rejects with gzip: stdin: not in gzip format. The script checks that the file is gzip and retries before extracting it.

Test plan

  • Confirm go test downloads a valid envtest archive and the controller suite starts.
  • Run make build and confirm the image build gets past make go-test.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid jira ticket of any type labels Oct 7, 2026
@openshift-ci

openshift-ci Bot commented Oct 7, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ttrishag

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting label Oct 7, 2026
@openshift-ci-robot

openshift-ci-robot commented Oct 7, 2026 •

Copy link
Copy Markdown

@ttrishag: This pull request references [Jira Issue DFBUGS-9260](https://redhat.atlassian.net/browse/DFBUGS-9260), which is invalid:

  • expected the vulnerability to target the "odf-4.14.29" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

https://redhat.atlassian.net/browse/RHSTOR-9714

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ttrishag
ttrishag force-pushed the DFBUGS-9260 branch 3 times, most recently from bca4154 to 9f274f7 Compare October 8, 2026 11:56
@openshift-ci-robot

openshift-ci-robot commented Oct 8, 2026 •

Copy link
Copy Markdown

@ttrishag: This pull request references [Jira Issue DFBUGS-9260](https://redhat.atlassian.net/browse/DFBUGS-9260), which is invalid:

  • expected the vulnerability to target the "odf-4.14.29" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

https://redhat.atlassian.net/browse/RHSTOR-9714

Summary

  • Replace golang.org/x/net with github.com/openshift-sustaining/net v0.35.0-sec.3 for DFBUGS-9260, and bump golang.org/x/sys, golang.org/x/term, and golang.org/x/text to match.
  • Download Kubernetes 1.28.3 envtest binaries from the controller-tools GitHub release. The old kubebuilder-tools bucket returns an error page, which tar then rejects with gzip: stdin: not in gzip format. The script checks that the file is gzip and retries before extracting it.

Test plan

  • Confirm go test downloads a valid envtest archive and the controller suite starts.
  • Run make build and confirm the image build gets past make go-test.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot

openshift-ci-robot commented Oct 8, 2026 •

Copy link
Copy Markdown

@ttrishag: This pull request references [Jira Issue DFBUGS-9260](https://redhat.atlassian.net/browse/DFBUGS-9260), which is invalid:

  • expected the vulnerability to target the "odf-4.14.29" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

https://redhat.atlassian.net/browse/RHSTOR-9714

Summary

  • Replace golang.org/x/net with github.com/openshift-sustaining/net v0.35.0-sec.3 for DFBUGS-9260, and bump golang.org/x/sys, golang.org/x/term, and golang.org/x/text to match.
  • Download Kubernetes 1.28.3 envtest binaries from the controller-tools GitHub release. The old kubebuilder-tools bucket returns an error page, which tar then rejects with gzip: stdin: not in gzip format. The script checks that the file is gzip and retries before extracting it.

Test plan

  • Confirm go test downloads a valid envtest archive and the controller suite starts.
  • Run make build and confirm the image build gets past make go-test.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ttrishag
ttrishag force-pushed the DFBUGS-9260 branch 6 times, most recently from 07820c0 to 8bfdb66 Compare October 8, 2026 12:45
Download the envtest archive from GitHub and verify it is gzip
before extracting it.

Signed-off-by: trishagupta <ttrishag19@gmail.com>
@leelavg

leelavg commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

@ttrishag why is there a RHSTOR ref in description?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid jira ticket of any type

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants