Skip to content

Implement core::error::Error for MqttError - #59

Merged
redboltz merged 1 commit into
redboltz:mainfrom
Pagten:implement-core-error-for-mqtt-error
Jan 19, 2026
Merged

redboltz merged 1 commit into
redboltz:mainfrom
Pagten:implement-core-error-for-mqtt-error

Conversation

@Pagten

@Pagten Pagten commented Jan 18, 2026

Copy link
Copy Markdown
Contributor

This one-liner PR provides a trivial core::error::Error implementation for MqttError. The advantage of implementing the Error trait for MqttError is that it makes the type compatible with various error handling libraries, such as anyhow and thiserror.

@codecov

codecov Bot commented Jan 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.91%. Comparing base (b1cc4d2) to head (d181ee6).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #59   +/-   ##
=======================================
  Coverage   90.91%   90.91%           
=======================================
  Files          55       55           
  Lines        7486     7486           
=======================================
  Hits         6806     6806           
  Misses        680      680           
Files with missing lines Coverage Δ
src/mqtt/result_code.rs 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@redboltz
redboltz merged commit d181ee6 into redboltz:main Jan 19, 2026
10 checks passed
@redboltz

Copy link
Copy Markdown
Owner

@Pagten , Thank you for sending the PR.
Looks good to me. Merged(Add tests and update version on #60)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants