Repository navigation
Clean up store when publish cannot be sent - #63
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
=======================================
Coverage 91.75% 91.75%
=======================================
Files 56 56
Lines 7436 7439 +3
=======================================
+ Hits 6823 6826 +3
Misses 613 613
🚀 New features to boost your workflow:
|
Owner
|
@jspngh , Thank you for sending the PR. It looks good to me. |
If the publish packet has been added to the store, it needs to be removed again if an error prevents it from being sent. Otherwise the packet_id, which has been released, may be used again for a next publish packet, which will cause a `PacketIdentifierConflict` when trying to add that to the store.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the publish packet has been added to the store, it needs to be removed again if an error prevents it from being sent.
Otherwise the packet_id, which has been released, may be used again for a next publish packet,
which will cause a
PacketIdentifierConflictwhen trying to add that to the store.This in turn causes a panic, since
unwrapis used when adding the packet to the store.I ran into this issue for the
ReceiveMaximumExceededcase.