Add dev-rdiUi feature flag - #6464
Conversation
Code Coverage - Backend unit tests
Test suite run success3779 tests passing in 325 suites. Report generated by 🧪jest coverage report action from 1d97176 |
Code Coverage - Frontend unit tests
Test suite run success8085 tests passing in 873 suites. Report generated by 🧪jest coverage report action from 1d97176 |
Code Coverage - Integration Tests
|
Adds a switchable dev flag to gate the upcoming rdi-ui integration, which will let RedisInsight render the new rdi-ui-powered pipeline management flow for RDI instances above a supported version, while keeping the current management flow as the default. Off for everyone by default, but locally overridable via ~/.redis-insight/config.json during development.
723bea7 to
bbf5f4b
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 723bea7e9f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit bbf5f4b. Configure here.
Installations that already persisted version 11 would never sync the new dev-rdiUi entry, since LocalFeaturesConfigService.sync() only updates stored config when the incoming version is greater than the current one. Flagged by review bot on PR #6464.

What
Adds a
dev-rdiUifeature flag (off by default,SwitchableFlagStrategy) as the first step of the rdi-ui integration. This flag will gate the upcoming new rdi-ui-powered pipeline management flow, rendered for RDI instances above a supported version, while the current management flow stays default for everyone else.No behavior changes yet — this PR only wires up the flag across backend and frontend:
features-config.json:dev-rdiUientry (flag: true,perc: [[0, 0]],filters: []) — off for all real users, but locally overridable.KnownFeaturesenum,known-features.ts, andfeature-flag.provider.ts(registered withSwitchableFlagStrategy).FeatureFlagsenum,features.tsdefault state, and anisDevRdiUiEnabledSelector(auto-enabled when runningnpm run dev:uilocally, mirroring thedev-languagepattern).Testing
npm run lintandnpm run type-checkpass.redisinsight/ui/src/slices/tests/app/features.spec.ts,redisinsight/api/src/modules/feature/providers/feature-flag/feature-flag.provider.spec.ts,redisinsight/api/src/modules/feature/local.feature.service.spec.ts./api/featuresthat the flag defaults tofalsewith no local override, and that adding{"features": {"dev-rdiUi": true}}to a localconfig.jsonoverride forces it on.No ticket yet.
Note
Low Risk
Additive feature-flag wiring only; defaults keep the flag off in non-dev builds with no routing or RDI UI changes yet.
Overview
Introduces a
dev-rdiUifeature flag end-to-end as groundwork for a future rdi-ui pipeline management flow, with no user-facing behavior in this PR.Config:
features-config.jsonversion bumps to 12 and addsdev-rdiUiwithperc: [[0, 0]]so it stays off for production users while remaining locally overridable (same pattern asdev-language).Backend: Registers
DevRdiUiinKnownFeatures,known-features.ts, andFeatureFlagProviderwithSwitchableFlagStrategy.Frontend: Adds
devRdiUitoFeatureFlags, defaultflag: falsein Redux initial state, andisDevRdiUiEnabledSelector(auto-on whenapp.env === 'development', otherwise follows/api/features).Reviewed by Cursor Bugbot for commit 1d97176. Bugbot is set up for automated code reviews on this repo. Configure here.