Skip to content

Add dev-rdiUi feature flag - #6464

Open
ArtemHoruzhenko wants to merge 2 commits into
mainfrom
feature/rdi-ui/add-dev-flag
Open

Add dev-rdiUi feature flag#6464
ArtemHoruzhenko wants to merge 2 commits into
mainfrom
feature/rdi-ui/add-dev-flag

Conversation

@ArtemHoruzhenko

@ArtemHoruzhenko ArtemHoruzhenko commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

What

Adds a dev-rdiUi feature flag (off by default, SwitchableFlagStrategy) as the first step of the rdi-ui integration. This flag will gate the upcoming new rdi-ui-powered pipeline management flow, rendered for RDI instances above a supported version, while the current management flow stays default for everyone else.

No behavior changes yet — this PR only wires up the flag across backend and frontend:

  • features-config.json: dev-rdiUi entry (flag: true, perc: [[0, 0]], filters: []) — off for all real users, but locally overridable.
  • Backend: KnownFeatures enum, known-features.ts, and feature-flag.provider.ts (registered with SwitchableFlagStrategy).
  • Frontend: FeatureFlags enum, features.ts default state, and an isDevRdiUiEnabledSelector (auto-enabled when running npm run dev:ui locally, mirroring the dev-language pattern).

Testing

  • npm run lint and npm run type-check pass.
  • Relevant Jest suites pass: redisinsight/ui/src/slices/tests/app/features.spec.ts, redisinsight/api/src/modules/feature/providers/feature-flag/feature-flag.provider.spec.ts, redisinsight/api/src/modules/feature/local.feature.service.spec.ts.
  • Manually verified via /api/features that the flag defaults to false with no local override, and that adding {"features": {"dev-rdiUi": true}} to a local config.json override forces it on.

No ticket yet.


Note

Low Risk
Additive feature-flag wiring only; defaults keep the flag off in non-dev builds with no routing or RDI UI changes yet.

Overview
Introduces a dev-rdiUi feature flag end-to-end as groundwork for a future rdi-ui pipeline management flow, with no user-facing behavior in this PR.

Config: features-config.json version bumps to 12 and adds dev-rdiUi with perc: [[0, 0]] so it stays off for production users while remaining locally overridable (same pattern as dev-language).

Backend: Registers DevRdiUi in KnownFeatures, known-features.ts, and FeatureFlagProvider with SwitchableFlagStrategy.

Frontend: Adds devRdiUi to FeatureFlags, default flag: false in Redux initial state, and isDevRdiUiEnabledSelector (auto-on when app.env === 'development', otherwise follows /api/features).

Reviewed by Cursor Bugbot for commit 1d97176. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Code Coverage - Backend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 93.21% 16645/17857
🟡 Branches 75.66% 5390/7124
🟢 Functions 87.58% 2552/2914
🟢 Lines 93.07% 15921/17106

Test suite run success

3779 tests passing in 325 suites.

Report generated by 🧪jest coverage report action from 1d97176

@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Code Coverage - Frontend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 83.58% 28925/34608
🟡 Branches 69.69% 12320/17678
🟡 Functions 78.63% 7627/9700
🟢 Lines 84.04% 28118/33458

Test suite run success

8085 tests passing in 873 suites.

Report generated by 🧪jest coverage report action from 1d97176

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Code Coverage - Integration Tests

Status Category Percentage Covered / Total
🟡 Statements 79.89% 18452/23094
🟡 Branches 62.19% 8614/13851
🟡 Functions 67.92% 2509/3694
🟡 Lines 79.52% 17382/21858

@ArtemHoruzhenko
ArtemHoruzhenko marked this pull request as ready for review September 1, 2026 09:41
@ArtemHoruzhenko
ArtemHoruzhenko requested a review from a team as a code owner September 1, 2026 09:41
Adds a switchable dev flag to gate the upcoming rdi-ui integration,
which will let RedisInsight render the new rdi-ui-powered pipeline
management flow for RDI instances above a supported version, while
keeping the current management flow as the default. Off for everyone
by default, but locally overridable via ~/.redis-insight/config.json
during development.
@ArtemHoruzhenko
ArtemHoruzhenko force-pushed the feature/rdi-ui/add-dev-flag branch from 723bea7 to bbf5f4b Compare September 1, 2026 09:42

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 723bea7e9f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread redisinsight/api/config/features-config.json

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit bbf5f4b. Configure here.

Comment thread redisinsight/api/config/features-config.json
Installations that already persisted version 11 would never sync the
new dev-rdiUi entry, since LocalFeaturesConfigService.sync() only
updates stored config when the incoming version is greater than the
current one. Flagged by review bot on PR #6464.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants