Fix state manager lock isolation

[harsh21234i]

Summary

Fixes #6829.

This changes backend state manager internals so each manager instance owns its own _state_manager_lock instead of sharing a lock created at class-definition time.

Updated managers:

• StateManagerMemory
• StateManagerDisk
• StateManagerRedis

Redis was included because it had the same dataclasses.field(default=asyncio.Lock()) pattern as memory and disk.

Root cause

asyncio.Lock() was evaluated when the dataclass field was defined, so every instance of the same manager class received the same lock object.

Using default_factory=asyncio.Lock creates a fresh lock per manager instance.

The PR also corrects an existing unit-test assertion whose comment already said separate state-manager instances should not share locks, but whose assertion checked the opposite.

Validation

uv run pytest tests/units/test_state.py::test_state_manager_modify_state tests/units/istate/manager/test_manager_locks.py -q

Result: 6 passed.

uv run pytest tests/units --cov --no-cov-on-fail --cov-report=

Result: 6955 passed, 18 skipped.

uv run towncrier check --config pyproject.toml --dir . --compare-with upstream/main

Result: found news/6830.bugfix.md.

uv run pre-commit run --files reflex/istate/manager/memory.py reflex/istate/manager/disk.py reflex/istate/manager/redis.py tests/units/istate/manager/test_manager_locks.py tests/units/test_state.py news/6830.bugfix.md

Result: passed.

[greptile-apps]

Greptile Summary

This PR fixes state-manager lock isolation by creating each manager’s internal lock per instance rather than once at class definition.

• Uses default_factory=asyncio.Lock for the memory, disk, and Redis managers.
• Adds regression coverage for lock identity across separate manager instances.
• Isolates the disk-manager test directory and corrects an existing inverted assertion.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
reflex/istate/manager/memory.py	Creates the memory manager’s coordination lock per instance, matching the intended ownership boundary.
reflex/istate/manager/disk.py	Creates the disk manager’s coordination lock per instance without changing its constructor contract.
reflex/istate/manager/redis.py	Uses a per-instance lock factory while preserving the field’s existing init=False behavior.
tests/units/istate/manager/test_manager_locks.py	Adds focused regression coverage for lock isolation across all three manager implementations and isolates disk storage.
tests/units/test_state.py	Corrects the existing assertion to require distinct locks for distinct manager instances.

_{Reviews (4): Last reviewed commit: "Isolate disk state manager lock test" | Re-trigger Greptile}

[codspeed-hq]

Merging this PR will not alter performance

✅ 26 untouched benchmarks
⏩ 8 skipped benchmarks¹

---

_{Comparing harsh21234i:fix/state-manager-lock-factory (a8b6feb) with main (a08a061)}

Footnotes

1. 8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

[cubic-dev-ai]

No issues found across 4 files

_{Re-trigger cubic}

[cubic-dev-ai]

1 issue found and verified against the latest diff

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="tests/units/istate/manager/test_manager_locks.py">

<violation number="1" location="tests/units/istate/manager/test_manager_locks.py:25">
P3: Instantiating `StateManagerDisk()` in this lock-isolation test runs `__post_init__`, which creates the real app states directory and `_purge_expired_states()` deletes any stale `.pkl` files in it — filesystem side effects that the lock-isolation assertion doesn't need. If the test is run against a real states dir, it can delete state files. Consider isolating this (e.g., point `REFLEX_STATE_MANAGER_DISK_DEBOUNCE_SECONDS`/states dir at a tmp_path, or construct the object via `object.__new__`/`dataclasses` without `__post_init__`).</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic</sub>

[cubic-dev-ai]

No issues found across 6 files

_{Re-trigger cubic}

[cubic-dev-ai]

No issues found across 6 files

_{Re-trigger cubic}