refactor: Allow op and model initialisation to fail, and promises - #246
Open
tperami wants to merge 1 commit into
Open
refactor: Allow op and model initialisation to fail, and promises#246tperami wants to merge 1 commit into
tperami wants to merge 1 commit into
Conversation
OpModel allows initialisation to fail GenPromise allows initialisation and promise emission to fail
febyeji
reviewed
Sep 7, 2026
| ((∃ tid, Error s ∈ PState.run_tid isem prom tid finPs) | ||
| ∨ | ||
| (∃ tid ev, | ||
| PState.allowed_promises_tid isem prom certified finPs |
Collaborator
There was a problem hiding this comment.
I think we should consider the case where emit_promise returns Error "invalid promise". In certified mode, this branch still requires allowed_promises_tid, which requires the same promise call to return Ok. Therefore, it cannot return an Error here, and promise-emission failures can never be reported by the certified model. Could we handle the Error case before checking certification?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpModel allows initialisation to fail
GenPromise allows initialisation and promise emission to fail
This PR is part of a stack containing 2 PRs:
main