fix(macro): never lose the release of what a macro pressed by colonelpanic8 · Pull Request #1247 · rmk-rs/rmk

colonelpanic8 · 2026-10-12T05:16:19Z

Two ways a macro introduced in #1168 could leave Ctrl held: down LCtrl, pause_for_release, up LCtrl dropped its release half when four macros had filled the queue by the time the key came up, and a Vial reset or buffer write, or a Rynk SetMacro, during down LCtrl, delay, up LCtrl dropped the up with the rest of the macro. A press stopped at a pause now keeps a queue place for its release half, and a change that stops the macros releases what their down ops still hold, through the macro's own release path, so a key the user is physically holding stays down.

The releases after a stop play at the stopped macro's next step (the end of its current delay, or the next key event), since host writes don't wake the keyboard task.

Tests: macros::macro_release_half_is_never_dropped, vial::macro_reset_releases_what_the_macro_holds, and rynk_macro::macro_write_releases_what_the_macro_holds, each failing before its fix.

🤖 Generated with Claude Code

The ops after `pause_for_release` are queued when the macro key comes up. If four macros had filled the queue by then, that release half was dropped, so a macro like `down LCtrl, pause, up LCtrl` left Ctrl held. A press that stops at a pause now keeps a place in the queue for its release half, and a trigger that would take that place is the one dropped. A release half runs only for a press that kept a place. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

A Vial reset or buffer write, or a Rynk macro write, ends the macros playing by emptying the queue. A macro stopped between `down LCtrl` and its `up LCtrl` lost the release with the rest of its ops, and Ctrl stayed down. The macros now remember what their `down` ops pressed and their `up` ops have not released. A change that stops them releases those first, as the next macro steps, through the same release path as a macro's own `up`, so a key the user holds physically stays down. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

github-actions · 2026-10-12T08:00:42Z

Size Report

Example	main	PR	Diff	.text	.bss
`use_config/nrf52832_ble`	356.1 KiB	356.7 KiB	+0.18% ⬆️	+640	+32
`use_config/nrf52840_ble`	415.5 KiB	416.2 KiB	+0.15% ⬆️	+616	+32
`use_config/nrf52840_ble_split (central)`	488.1 KiB	488.8 KiB	+0.13% ⬆️	+648	+32
`use_config/nrf52840_ble_split (peripheral)`	310.1 KiB	310.1 KiB	+0.00%	0	0
`use_config/pi_pico_w_ble`	657.7 KiB	658.2 KiB	+0.08% ⬆️	+516	+32
`use_config/rp2040`	140.4 KiB	141.0 KiB	+0.42% ⬆️	+572	+40
`use_config/rp2040_split (central)`	155.7 KiB	156.4 KiB	+0.42% ⬆️	+640	+32
`use_config/rp2040_split (peripheral)`	28.3 KiB	28.3 KiB	+0.00%	0	0
`use_config/stm32f1`	59.6 KiB	60.1 KiB	+0.87% ⬆️	+496	+40
`use_config/stm32h7`	98.6 KiB	99.1 KiB	+0.49% ⬆️	+460	+40
`use_rust/nrf52832_ble`	347.2 KiB	347.6 KiB	+0.11% ⬆️	+376	+32
`use_rust/nrf52840_ble`	413.3 KiB	413.9 KiB	+0.15% ⬆️	+608	+40
`use_rust/nrf52840_ble_split (central)`	489.4 KiB	490.1 KiB	+0.13% ⬆️	+620	+40
`use_rust/nrf52840_ble_split (peripheral)`	302.0 KiB	302.0 KiB	+0.00%	0	0
`use_rust/pi_pico_w_ble`	657.4 KiB	658.3 KiB	+0.12% ⬆️	+824	+32
`use_rust/rp2040`	140.1 KiB	140.8 KiB	+0.44% ⬆️	+600	+32
`use_rust/rp2040_split (central)`	155.0 KiB	155.7 KiB	+0.42% ⬆️	+632	+40
`use_rust/rp2040_split (peripheral)`	28.8 KiB	28.8 KiB	+0.00%	0	0
`use_rust/stm32f1`	59.1 KiB	59.5 KiB	+0.71% ⬆️	+392	+40
`use_rust/stm32h7`	116.1 KiB	116.7 KiB	+0.50% ⬆️	+564	+40

use_config/nrf52832_ble — 356.1 KiB → 356.7 KiB (+0.18% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 326996	   8600	  29680	 365276	  592dc	rmk-nrf52832

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 326356	   8600	  29648	 364604	  5903c	rmk-nrf52832

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.4% +14.4Ki  [ = ]       0    .debug_str
  +0.4% +7.08Ki  [ = ]       0    .debug_info
  +0.2% +1.27Ki  [ = ]       0    .debug_loc
  +0.3%    +834  [ = ]       0    .debug_line
  +0.3%    +656  [ = ]       0    .debug_ranges
  +0.2%    +640  +0.2%    +640    .text
  +0.1%    +221  [ = ]       0    .strtab
  +0.1%     +48  [ = ]       0    .debug_frame
  [ = ]       0  +0.1%     +32    .bss
  +0.0%     +32  [ = ]       0    .symtab
  +0.0%      +8  [ = ]       0    .debug_aranges
  +0.3% +25.1Ki  +0.2%    +672    TOTAL

use_config/nrf52840_ble — 415.5 KiB → 416.2 KiB (+0.15% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 376620	   8636	  40888	 426144	  680a0	rmk-nrf52840

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 376004	   8636	  40856	 425496	  67e18	rmk-nrf52840

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.4% +18.2Ki  [ = ]       0    .debug_str
  +0.3% +6.30Ki  [ = ]       0    .debug_info
  +0.3%    +907  [ = ]       0    .strtab
  +0.2%    +616  +0.2%    +616    .text
  +0.3%    +352  [ = ]       0    .symtab
  +0.1%    +304  [ = ]       0    .debug_line
  +0.1%    +240  [ = ]       0    .debug_ranges
  +0.4%    +176  [ = ]       0    .debug_frame
  +0.0%    +149  [ = ]       0    .debug_loc
  +0.1%     +72  [ = ]       0    .debug_aranges
  [ = ]       0  +0.1%     +32    .bss
  -9.8%      -5  [ = ]       0    [Unmapped]
  +0.3% +27.2Ki  +0.2%    +648    TOTAL

use_config/nrf52840_ble_split (central) — 488.1 KiB → 488.8 KiB (+0.13% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 445268	   8684	  46528	 500480	  7a300	central

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 444620	   8684	  46496	 499800	  7a058	central

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.2% +10.8Ki  [ = ]       0    .debug_str
  +0.2% +4.82Ki  [ = ]       0    .debug_info
  +0.2% +1.47Ki  [ = ]       0    .debug_loc
  +0.2%    +648  +0.2%    +648    .text
  +0.2%    +424  [ = ]       0    .debug_ranges
  +0.1%    +283  [ = ]       0    .debug_line
  +0.1%    +214  [ = ]       0    .strtab
  +0.1%    +128  [ = ]       0    .symtab
  +0.1%     +64  [ = ]       0    .debug_frame
  +0.4%     +39  [ = ]       0    .debug_abbrev
  [ = ]       0  +0.1%     +32    .bss
  +0.0%     +16  [ = ]       0    .debug_aranges
 -19.7%     -12  [ = ]       0    [Unmapped]
  +0.2% +18.8Ki  +0.1%    +680    TOTAL

use_config/nrf52840_ble_split (peripheral) — 310.1 KiB → 310.1 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 286096	   8516	  22912	 317524	  4d854	peripheral

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 286096	   8516	  22912	 317524	  4d854	peripheral

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -0.0%      -2  [ = ]       0    .strtab
  -0.0%      -6  [ = ]       0    .debug_str
  -0.0%      -8  [ = ]       0    TOTAL

use_config/pi_pico_w_ble — 657.7 KiB → 658.2 KiB (+0.08% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 623232	      0	  50756	 673988	  a48c4	rmk-pi-pico-w

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 622716	      0	  50724	 673440	  a46a0	rmk-pi-pico-w

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.3% +14.2Ki  [ = ]       0    .debug_str
  +0.3% +7.00Ki  [ = ]       0    .debug_info
  +0.2%    +799  [ = ]       0    .debug_line
  +0.2%    +528  [ = ]       0    .debug_ranges
  +0.2%    +516  +0.2%    +516    .text
  +0.1%    +203  [ = ]       0    .strtab
  +0.1%     +64  [ = ]       0    .symtab
  +0.1%     +60  [ = ]       0    .debug_frame
  [ = ]       0  +0.1%     +32    .bss
  +0.0%     +16  [ = ]       0    .debug_aranges
  -2.0%      -1  [ = ]       0    [Unmapped]
  -0.0%    -559  [ = ]       0    .debug_loc
  +0.2% +22.8Ki  +0.1%    +548    TOTAL

use_config/rp2040 — 140.4 KiB → 141.0 KiB (+0.42% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 133204	      0	  11132	 144336	  233d0	rmk-rp2040

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 132632	      0	  11092	 143724	  2316c	rmk-rp2040

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.8% +15.0Ki  [ = ]       0    .debug_str
  +0.7% +6.79Ki  [ = ]       0    .debug_info
  +0.5% +1.50Ki  [ = ]       0    .debug_loc
  +0.4%    +672  [ = ]       0    .debug_line
  +0.5%    +572  +0.5%    +572    .text
  +0.7%    +568  [ = ]       0    .debug_ranges
  +0.2%    +238  [ = ]       0    .strtab
  +0.4%    +128  [ = ]       0    .symtab
  +0.3%     +60  [ = ]       0    .debug_frame
  [ = ]       0  +0.4%     +40    .bss
  +0.1%     +16  [ = ]       0    .debug_aranges
  +7.0%      +4  [ = ]       0    [Unmapped]
  +0.7% +25.5Ki  +0.4%    +612    TOTAL

use_config/rp2040_split (central) — 155.7 KiB → 156.4 KiB (+0.42% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 147932	      0	  12220	 160152	  27198	central

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 147292	      0	  12188	 159480	  26ef8	central

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.6% +14.2Ki  [ = ]       0    .debug_str
  +0.6% +6.81Ki  [ = ]       0    .debug_info
  +0.4%    +702  [ = ]       0    .debug_line
  +0.5%    +640  +0.5%    +640    .text
  +0.1%    +415  [ = ]       0    .debug_loc
  +0.3%    +328  [ = ]       0    .debug_ranges
  +0.1%    +200  [ = ]       0    .strtab
  +0.4%    +160  [ = ]       0    .symtab
  +0.3%     +60  [ = ]       0    .debug_frame
  [ = ]       0  +0.3%     +32    .bss
  +0.1%     +16  [ = ]       0    .debug_aranges
  +1.9%      +1  [ = ]       0    [Unmapped]
  +0.5% +23.5Ki  +0.4%    +672    TOTAL

use_config/rp2040_split (peripheral) — 28.3 KiB → 28.3 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
  25948	     60	   2964	  28972	   712c	peripheral

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
  25948	     60	   2964	  28972	   712c	peripheral

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -1.8%      -1  [ = ]       0    [Unmapped]
  -0.0%    -107  [ = ]       0    .debug_str
  -0.0%    -108  [ = ]       0    TOTAL

use_config/stm32f1 — 59.6 KiB → 60.1 KiB (+0.87% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
  54992	     32	   6560	  61584	   f090	rmk-stm32f1

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
  54496	     32	   6520	  61048	   ee78	rmk-stm32f1

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +1.4% +13.7Ki  [ = ]       0    .debug_str
  +1.2% +6.54Ki  [ = ]       0    .debug_info
  +1.8% +2.40Ki  [ = ]       0    .debug_loc
  +0.7%    +593  [ = ]       0    .debug_line
  +1.3%    +544  [ = ]       0    .debug_ranges
  +0.9%    +496  +0.9%    +496    .text
  +0.9%    +357  [ = ]       0    .strtab
  +0.4%     +44  [ = ]       0    .debug_frame
  [ = ]       0  +0.6%     +40    .bss
  +0.2%     +32  [ = ]       0    .symtab
   +43%     +20  [ = ]       0    [Unmapped]
  +0.1%      +8  [ = ]       0    .debug_aranges
  +1.3% +24.6Ki  +0.9%    +536    TOTAL

use_config/stm32h7 — 98.6 KiB → 99.1 KiB (+0.49% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
  92648	    268	   8560	 101476	  18c64	rmk-stm32h7

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
  92188	    268	   8520	 100976	  18a70	rmk-stm32h7

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.7% +14.6Ki  [ = ]       0    .debug_str
  +0.7% +6.81Ki  [ = ]       0    .debug_info
  +1.3% +2.33Ki  [ = ]       0    .debug_loc
  +0.9%    +600  [ = ]       0    .debug_ranges
  +0.4%    +502  [ = ]       0    .debug_line
  +0.6%    +460  +0.6%    +460    .text
  +0.3%    +207  [ = ]       0    .strtab
  +0.2%     +64  [ = ]       0    .symtab
  +0.3%     +48  [ = ]       0    .debug_frame
  [ = ]       0  +0.5%     +40    .bss
   +51%     +21  [ = ]       0    [Unmapped]
  +0.0%      +8  [ = ]       0    .debug_aranges
  +0.7% +25.6Ki  +0.5%    +500    TOTAL

use_rust/nrf52832_ble — 347.2 KiB → 347.6 KiB (+0.11% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 317764	   8608	  29616	 355988	  56e94	rmk-nrf52832

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 317388	   8608	  29584	 355580	  56cfc	rmk-nrf52832

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.4% +14.1Ki  [ = ]       0    .debug_str
  +0.4% +6.70Ki  [ = ]       0    .debug_info
  +0.3% +2.14Ki  [ = ]       0    .debug_loc
  +0.1%    +395  [ = ]       0    .debug_line
  +0.1%    +376  +0.1%    +376    .text
  +0.1%    +288  [ = ]       0    .strtab
  +0.1%    +200  [ = ]       0    .debug_ranges
  +0.1%    +128  [ = ]       0    .symtab
  +0.2%     +64  [ = ]       0    .debug_frame
  [ = ]       0  +0.1%     +32    .bss
  +0.0%     +16  [ = ]       0    .debug_aranges
   +35%     +13  [ = ]       0    [Unmapped]
  +0.3% +24.4Ki  +0.1%    +408    TOTAL

use_rust/nrf52840_ble — 413.3 KiB → 413.9 KiB (+0.15% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 377176	   8644	  38048	 423868	  677bc	rmk-nrf52840

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 376568	   8644	  38008	 423220	  67534	rmk-nrf52840

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.4% +18.6Ki  [ = ]       0    .debug_str
  +0.3% +6.92Ki  [ = ]       0    .debug_info
  +0.2%    +733  [ = ]       0    .strtab
  +0.2%    +608  +0.2%    +608    .text
  +0.2%    +532  [ = ]       0    .debug_line
  +0.2%    +448  [ = ]       0    .debug_ranges
  +0.2%    +224  [ = ]       0    .symtab
  +0.2%     +96  [ = ]       0    .debug_frame
  [ = ]       0  +0.1%     +40    .bss
  +0.1%     +32  [ = ]       0    .debug_aranges
  +5.6%      +3  [ = ]       0    [Unmapped]
  -0.4%     -39  [ = ]       0    .debug_abbrev
  -0.1%    -525  [ = ]       0    .debug_loc
  +0.3% +27.6Ki  +0.2%    +648    TOTAL

use_rust/nrf52840_ble_split (central) — 489.4 KiB → 490.1 KiB (+0.13% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 445116	   8684	  48040	 501840	  7a850	central

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 444496	   8684	  48000	 501180	  7a5bc	central

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.3% +14.2Ki  [ = ]       0    .debug_str
  +0.3% +6.75Ki  [ = ]       0    .debug_info
  +0.2% +1.62Ki  [ = ]       0    .debug_loc
  +0.2%    +821  [ = ]       0    .debug_line
  +0.2%    +620  +0.2%    +620    .text
  +0.2%    +440  [ = ]       0    .debug_ranges
  +0.1%    +426  [ = ]       0    .strtab
  +0.3%    +384  [ = ]       0    .symtab
  +0.3%    +176  [ = ]       0    .debug_frame
  +0.1%     +72  [ = ]       0    .debug_aranges
  [ = ]       0  +0.1%     +40    .bss
  +0.4%     +39  [ = ]       0    .debug_abbrev
   +30%     +17  [ = ]       0    [Unmapped]
  +0.3% +25.5Ki  +0.1%    +660    TOTAL

use_rust/nrf52840_ble_split (peripheral) — 302.0 KiB → 302.0 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 278228	   8516	  22456	 309200	  4b7d0	peripheral

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 278228	   8516	  22456	 309200	  4b7d0	peripheral

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -0.0%      -2  [ = ]       0    .strtab
  -0.0%      -6  [ = ]       0    .debug_str
  -0.0%      -8  [ = ]       0    TOTAL

use_rust/pi_pico_w_ble — 657.4 KiB → 658.3 KiB (+0.12% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 623644	      0	  50436	 674080	  a4920	rmk-pi-pico-w

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 622820	      0	  50404	 673224	  a45c8	rmk-pi-pico-w

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.3% +15.2Ki  [ = ]       0    .debug_str
  +0.3% +7.08Ki  [ = ]       0    .debug_info
  +0.3% +3.00Ki  [ = ]       0    .debug_loc
  +0.3% +1.21Ki  [ = ]       0    .debug_line
  +0.4%    +952  [ = ]       0    .debug_ranges
  +0.3%    +824  +0.3%    +824    .text
  +0.1%    +221  [ = ]       0    .strtab
  +0.2%    +160  [ = ]       0    .symtab
  +0.1%     +60  [ = ]       0    .debug_frame
  [ = ]       0  +0.1%     +32    .bss
  +0.0%     +16  [ = ]       0    .debug_aranges
   +22%     +10  [ = ]       0    [Unmapped]
  +0.3% +28.7Ki  +0.1%    +856    TOTAL

use_rust/rp2040 — 140.1 KiB → 140.8 KiB (+0.44% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 133176	      0	  10964	 144140	  2330c	rmk-rp2040

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 132576	      0	  10932	 143508	  23094	rmk-rp2040

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.8% +15.0Ki  [ = ]       0    .debug_str
  +0.7% +6.88Ki  [ = ]       0    .debug_info
  +0.4%    +728  [ = ]       0    .debug_line
  +0.5%    +600  +0.5%    +600    .text
  +0.4%    +368  [ = ]       0    .debug_ranges
  +0.1%    +241  [ = ]       0    .debug_loc
  +0.2%    +219  [ = ]       0    .strtab
  +0.3%    +112  [ = ]       0    .symtab
  +0.3%     +60  [ = ]       0    .debug_frame
  [ = ]       0  +0.3%     +32    .bss
  +0.1%     +16  [ = ]       0    .debug_aranges
   +19%      +9  [ = ]       0    [Unmapped]
  +0.6% +24.2Ki  +0.4%    +632    TOTAL

use_rust/rp2040_split (central) — 155.0 KiB → 155.7 KiB (+0.42% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 147456	      0	  11964	 159420	  26ebc	central

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 146824	      0	  11924	 158748	  26c1c	central

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.6% +14.2Ki  [ = ]       0    .debug_str
  +0.6% +6.83Ki  [ = ]       0    .debug_info
  +0.3% +1.17Ki  [ = ]       0    .debug_loc
  +0.4%    +665  [ = ]       0    .debug_line
  +0.5%    +632  +0.5%    +632    .text
  +0.5%    +496  [ = ]       0    .debug_ranges
  +0.7%    +240  [ = ]       0    .symtab
  +0.2%    +215  [ = ]       0    .strtab
  +0.3%     +60  [ = ]       0    .debug_frame
  [ = ]       0  +0.4%     +40    .bss
  +0.1%     +16  [ = ]       0    .debug_aranges
   +15%      +6  [ = ]       0    [Unmapped]
  +0.6% +24.5Ki  +0.4%    +672    TOTAL

use_rust/rp2040_split (peripheral) — 28.8 KiB → 28.8 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
  26176	     60	   3228	  29464	   7318	peripheral

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
  26176	     60	   3228	  29464	   7318	peripheral

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -1.9%      -1  [ = ]       0    [Unmapped]
  -0.0%    -107  [ = ]       0    .debug_str
  -0.0%    -108  [ = ]       0    TOTAL

use_rust/stm32f1 — 59.1 KiB → 59.5 KiB (+0.71% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
  54452	     32	   6480	  60964	   ee24	rmk-stm32f1

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
  54060	     32	   6440	  60532	   ec74	rmk-stm32f1

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +1.6% +14.2Ki  [ = ]       0    .debug_str
  +1.3% +7.35Ki  [ = ]       0    .debug_info
  +1.1% +1.40Ki  [ = ]       0    .debug_loc
  +0.6%    +480  [ = ]       0    .debug_line
  +0.7%    +392  +0.7%    +392    .text
  +1.0%    +388  [ = ]       0    .strtab
  +0.3%    +136  [ = ]       0    .debug_ranges
  +0.5%     +96  [ = ]       0    .symtab
  +0.5%     +60  [ = ]       0    .debug_frame
  [ = ]       0  +0.6%     +40    .bss
  +0.4%     +16  [ = ]       0    .debug_aranges
 -11.3%      -8  [ = ]       0    [Unmapped]
  +1.3% +24.5Ki  +0.7%    +432    TOTAL

use_rust/stm32h7 — 116.1 KiB → 116.7 KiB (+0.50% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 107816	    408	  11232	 119456	  1d2a0	rmk-stm32h7

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 107252	    408	  11192	 118852	  1d044	rmk-stm32h7

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.6% +15.0Ki  [ = ]       0    .debug_str
  +0.6% +6.88Ki  [ = ]       0    .debug_info
  +0.9% +2.32Ki  [ = ]       0    .debug_loc
  +0.4%    +628  [ = ]       0    .debug_line
  +0.5%    +564  +0.5%    +564    .text
  +0.5%    +392  [ = ]       0    .debug_ranges
  +0.2%    +240  [ = ]       0    .strtab
  +0.4%    +128  [ = ]       0    .symtab
  +0.4%     +80  [ = ]       0    .debug_frame
  [ = ]       0  +0.4%     +40    .bss
  +0.4%     +24  [ = ]       0    .debug_abbrev
  +0.1%     +24  [ = ]       0    .debug_aranges
   +26%     +10  [ = ]       0    [Unmapped]
  +0.6% +26.3Ki  +0.5%    +604    TOTAL

colonelpanic8 and others added 2 commits October 11, 2026 22:11

HaoboGu marked this pull request as draft October 12, 2026 07:03

Navigation Menu

Repository navigation

fix(macro): never lose the release of what a macro pressed - #1247

fix(macro): never lose the release of what a macro pressed#1247
colonelpanic8 wants to merge 2 commits into
rmk-rs:mainfrom
colonelpanic8:fix/macro-release-ownership

colonelpanic8 commented Oct 12, 2026

Uh oh!

github-actions Bot commented Oct 12, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

colonelpanic8 commented Oct 12, 2026

Uh oh!

github-actions Bot commented Oct 12, 2026

Size Report

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant