chore: project housekeeping, added missing packages, enabled typings … by hinogi · Pull Request #1140 · roboflow/rf-detr

hinogi · 2026-06-19T20:39:19Z

…for modules with no source

What does this PR do?

Added missing modules to the dep lists
enabled generation of typing stubs for modules without sourcecode
enabled dependency checking

Related Issue(s):

Type of Change

Refactoring (no functional changes)

Testing

I have tested this change locally
I have added/updated tests for this change

Test details:

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code where necessary, particularly in hard-to-understand areas
My changes generate no new warnings or errors
I have updated the documentation accordingly (if applicable)

Additional Context

…for modules with no source

socket-security · 2026-06-19T20:40:17Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	pypi/opencv-python@5.0.0.93
	pypi/deptry@0.25.1

View full report

codecov · 2026-06-19T20:47:08Z

Codecov Report

❌ Patch coverage is 75.94937% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 83%. Comparing base (72337cf) to head (ecdd8c7).
⚠️ Report is 2 commits behind head on develop.

❌ Your patch check has failed because the patch coverage (76%) is below the target coverage (95%). You can increase the patch coverage or adjust the target coverage.
❌ Your project check has failed because the head coverage (83%) is below the target coverage (95%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

@@           Coverage Diff           @@
##           develop   #1140   +/-   ##
=======================================
  Coverage       82%     83%           
=======================================
  Files          111     111           
  Lines        11972   12011   +39     
=======================================
+ Hits          9856    9914   +58     
+ Misses        2116    2097   -19

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Borda · 2026-06-22T18:23:42Z

+    "pillow>=12.2.0",
+    "pyyaml>=6.0.3",
+    "rich>=15.0.0",
+    "opencv-python>=4.11.0.86",
+    "opencv-python-headless>=4.10.0.84",


Why do you need to list them explicitly? Are there any version changes?

if you remove

"opencv-python>=4.11.0.86", "opencv-python-headless>=4.10.0.84",

you get this for example

❯ uv run pytest .\tests\evaluation\test_coco_eval.py ImportError while loading conftest 'C:\Users\Stefan\code\rf-detr-workin\tests\conftest.py'. tests\conftest.py:12: in <module> from rfdetr.datasets.synthetic import DatasetSplitRatios, generate_coco_dataset src\rfdetr\datasets\synthetic.py:20: in <module> from supervision import Color, Detections, box_iou_batch, draw_filled_polygon .venv\Lib\site-packages\supervision\__init__.py:9: in <module> from supervision.annotators.core import ( .venv\Lib\site-packages\supervision\annotators\core.py:40: in <module> from supervision.draw.utils import draw_polygon, draw_rounded_rectangle, draw_text .venv\Lib\site-packages\supervision\draw\utils.py:226: in <module> text_font: int = cv2.FONT_HERSHEY_SIMPLEX, ^^^^^^^^^^^^^^^^^^^^^^^^ E AttributeError: module 'cv2' has no attribute 'FONT_HERSHEY_SIMPLEX'

My MO was to check all import and try to find them in the pyproject.toml and if they do not exist add them to make the tooling happy.
I don't know if it is dependent on the arch or the IDE if such things come up but there seem to be a lot of caveats that I triggered.

Also I did not pick the version myself I just did uv add

Copilot

Pull request overview

This PR updates the project’s packaging and tooling configuration in pyproject.toml to support dependency hygiene (deptry), add “missing” runtime dependencies, and introduce a dev extra.

Changes:

Added several packages to the core dependencies list (e.g., Pillow, PyYAML, Rich, OpenCV).
Added a dev optional-dependency extra (deptry + pytest).
Added a [tool.deptry] configuration section and a [tool.uv] environments setting.

Borda · 2026-06-23T15:38:25Z

+    "rich>=15.0.0",
+    "opencv-python>=4.11.0.86",
+    "opencv-python-headless>=4.10.0.84",


I do not know what is the best approach for what are actual dependencies that are necessary at runtime or development or just testing so I moved/added this to testing since that obviously does not work without them, but also maybe @Borda you can put those in the correct group or tell me how to find out where they should go since I also did only did execute a single test and got all that errors already.

if opencv is missing in test

ImportError while loading conftest 'C:\Users\Stefan\code\rf-detr-workin\tests\conftest.py'. tests\conftest.py:12: in <module> from rfdetr.datasets.synthetic import DatasetSplitRatios, generate_coco_dataset src\rfdetr\datasets\synthetic.py:20: in <module> from supervision import Color, Detections, box_iou_batch, draw_filled_polygon .venv\Lib\site-packages\supervision\__init__.py:9: in <module> from supervision.annotators.core import ( .venv\Lib\site-packages\supervision\annotators\core.py:40: in <module> from supervision.draw.utils import draw_polygon, draw_rounded_rectangle, draw_text .venv\Lib\site-packages\supervision\draw\utils.py:226: in <module> text_font: int = cv2.FONT_HERSHEY_SIMPLEX, ^^^^^^^^^^^^^^^^^^^^^^^^ E AttributeError: module 'cv2' has no attribute 'FONT_HERSHEY_SIMPLEX'

when faster_coco_eval is missing in test

__________________________________________ ERROR collecting tests/evaluation/test_coco_eval.py ______________________________________________ tests\evaluation\test_coco_eval.py:16: in <module> from faster_coco_eval import COCO E ModuleNotFoundError: No module named 'faster_coco_eval' ______________________________________________ ERROR collecting tests/evaluation/test_coco_eval.py ______________________________________________ ImportError while importing test module 'C:\Users\Stefan\code\rf-detr-workin\tests\evaluation\test_coco_eval.py'. Hint: make sure your test modules/packages have valid Python names. Traceback: ..\..\AppData\Roaming\uv\python\cpython-3.12.10-windows-x86_64-none\Lib\importlib\__init__.py:90: in import_module return _bootstrap._gcd_import(name[level:], package, level) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ tests\evaluation\test_coco_eval.py:16: in <module> from faster_coco_eval import COCO E ModuleNotFoundError: No module named 'faster_coco_eval'

if pycocotools is missing in test

______________________________________________ ERROR collecting tests/evaluation/test_coco_eval.py ______________________________________________ tests\evaluation\test_coco_eval.py:13: in <module> import pycocotools.coco as pycoco E ModuleNotFoundError: No module named 'pycocotools' ______________________________________________ ERROR collecting tests/evaluation/test_coco_eval.py ______________________________________________ ImportError while importing test module 'C:\Users\Stefan\code\rf-detr-workin\tests\evaluation\test_coco_eval.py'. Hint: make sure your test modules/packages have valid Python names. Traceback: ..\..\AppData\Roaming\uv\python\cpython-3.12.10-windows-x86_64-none\Lib\importlib\__init__.py:90: in import_module return _bootstrap._gcd_import(name[level:], package, level) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ tests\evaluation\test_coco_eval.py:13: in <module> import pycocotools.coco as pycoco E ModuleNotFoundError: No module named 'pycocotools'

@Borda Any advice on how to move forward?

❯ Get-ChildItem "C:\Users\Stefan\code\rf-detr-workin\.venv\Lib\site-packages\cv2" Directory: C:\Users\Stefan\code\rf-detr-workin\.venv\Lib\site-packages\cv2 Mode LastWriteTime Length Name ---- ------------- ------ ---- -a--- 19.06.2026 12:25 27954688 opencv_videoio_ffmpeg4110_64.dll

guess I found another reason, corrupt package installation

- Fixed prediction, export, deploy, and benchmarking behavior, including safer URL loading, correct return typing, optimized-model guards, second-training warnings, dynamic input/query handling, and clamped benchmark top-k. - Fixed dataset loading and augmentation edge cases, including bounded large-image handling, seeded DataLoader workers, configurable Albumentations strictness, corrected non-square resize-crop jitter, GaussianBlur sigma passthrough, and asymmetric blur-range warnings. - Fixed training and model stability issues, including graph-connected zero mask losses for empty matches, preserved process RNG during training, corrected MultiScaleProjector survival-drop behavior, and removal of obsolete torchvision compatibility logic. - Fixed box IoU/GIoU NaNs for degenerate boxes while preserving exact IoU for normal boxes. - Improved mask postprocessing memory usage by chunking interpolation and storing thresholded boolean masks. - Updated documentation for export, migration, training, installation extras, benchmarks, references, and LLM metadata to match shipped behavior. - Fixed tests and smoke coverage for checkpoint errors, optimized-model state, mask memory handling, box degeneracy, worker seeding, CLI execution, and updated resize-crop behavior. --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>

…ork consider --reinstall of the package not working

chore: project housekeeping, added missing packages, enabled typings …

18992ac

…for modules with no source

hinogi requested review from Borda, SkalskiP, isaacrob and probicheaux as code owners June 19, 2026 20:39

Merge branch 'roboflow:develop' into chore/housekeeping-missing-deps

bc35a97

Borda reviewed Jun 19, 2026

View reviewed changes

Comment thread pyproject.toml Outdated

hinogi commented Jun 19, 2026

View reviewed changes

Comment thread pyproject.toml Outdated

hinogi added 3 commits June 20, 2026 00:53

Apply suggestion from @hinogi

3d10713

fix: removed double dependencie from other groups

2f44c2d

refactor: removed typing generation

9f5a92b

Borda added the enhancement New feature or request label Jun 22, 2026

Borda reviewed Jun 22, 2026

View reviewed changes

Borda requested a review from Copilot June 22, 2026 18:23

Copilot started reviewing on behalf of Borda June 22, 2026 18:24 View session

Copilot AI reviewed Jun 22, 2026

View reviewed changes

hinogi and others added 4 commits June 23, 2026 17:47

refactor: moved packages from dep to test, added missing deps to test

8e065cc

Merge branch 'roboflow:develop' into chore/housekeeping-missing-deps

7bb82bf

tests: added deps that where missing during steps, if still doesn't w…

ecdd8c7

…ork consider --reinstall of the package not working

Borda force-pushed the develop branch from e59d6f5 to 42e05c8 Compare July 3, 2026 17:22

github-actions Bot added the has conflicts label Jul 3, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: project housekeeping, added missing packages, enabled typings …#1140

chore: project housekeeping, added missing packages, enabled typings …#1140
hinogi wants to merge 9 commits into
roboflow:developfrom
hinogi:chore/housekeeping-missing-deps

hinogi commented Jun 19, 2026

Uh oh!

socket-security Bot commented Jun 19, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Jun 19, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Borda Jun 22, 2026

Uh oh!

hinogi Jun 22, 2026 •

edited

Loading

Uh oh!

hinogi Jun 22, 2026

Uh oh!

hinogi Jun 22, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Borda Jun 23, 2026

Uh oh!

hinogi Jun 23, 2026

Uh oh!

hinogi Jul 1, 2026

Uh oh!

hinogi Jul 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

hinogi commented Jun 19, 2026

What does this PR do?

Type of Change

Testing

Checklist

Additional Context

Uh oh!

socket-security Bot commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Borda Jun 22, 2026

Choose a reason for hiding this comment

Uh oh!

hinogi Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hinogi Jun 22, 2026

Choose a reason for hiding this comment

Uh oh!

hinogi Jun 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Borda Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

hinogi Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

hinogi Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

hinogi Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

socket-security Bot commented Jun 19, 2026 •

edited

Loading

codecov Bot commented Jun 19, 2026 •

edited

Loading

hinogi Jun 22, 2026 •

edited

Loading