Conversation
Forward the disabled-by-default web-worker feature to winit. Adopt the page-owned canvas without querying a worker document or overwriting its parent sizing. Pin the companion winit implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows Bevy's winit integration to use a canvas attached to a dedicated worker. Adds a disabled-by-default
web-workerfeature and skips page-only canvas lookup and parent sizing when the worker owns the canvas.Five files, 21 additions and two deletions. The existing native and non-worker paths remain unchanged. Depends on robtfm/winit#1; the Cargo patch currently pins its public
eordano/winitrevision and should move to the merged revision when available.Validation:
bevy_winitchecks pass with the feature both disabled and enabled.This draft covers the engine integration. Moving Explorer's own bootstrap and browser APIs into a worker is separate application work.