Skip to content

question about ScanMatcher::score #15

Open

Description

@asmashine

in this function ,to caculate pfree,there are
double freeDelta=map.getDelta()*m_freeCellRatio;and
pfree.x+=(*r-map.getDelta()*freeDelta)*cos(lp.theta+*angle); pfree.y+=(*r-map.getDelta()*freeDelta)*sin(lp.theta+*angle);;
obviously r - delta^2sqrt(2) (freeDelta = sqrt(2))
i think r - delta
sqart(2) can show the range of pfree ,but the equation above i don't know its mean.

Activity

  1. lmy19880626 commented on May 9, 2017

    @lmy19880626

    me too! I need the explanation.

  2. KOTOKORURU commented on Mar 9, 2018

    @KOTOKORURU

    I have the same question ,have you sloved it?

  3. 1344618323 commented on Aug 10, 2019

    @1344618323

    me too! I think there's a bug!

  4. topin89 commented on Nov 3, 2019

    @topin89

    I think this is a bug that was shadowed by another bug, #25
    making everything about pfree, ipfree, pf and fcell irrelevant.

    And yes,

    pfree.x+=(*r-map.getDelta()*freeDelta)*cos(lp.theta+*angle);
    pfree.y+=(*r-map.getDelta()*freeDelta)*sin(lp.theta+*angle);
    

    should be replaced with

    pfree.x+=(*r-*freeDelta)*cos(lp.theta+*angle);
    pfree.y+=(*r-*freeDelta)*sin(lp.theta+*angle);
    

    With these two bugs solved, gmapping stops looking for best score inside a wall.

  5. topin89 commented on Nov 3, 2019

    @topin89

    Oh, there is a PR to fix that: #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions