Skip to content

Replace dead icon source with original octicons from github - #218

Open
dvg-p4 wants to merge 1 commit into
rstudio:mainfrom
dvg-p4:replace-dead-icon
Open

dvg-p4 wants to merge 1 commit into
rstudio:mainfrom
dvg-p4:replace-dead-icon

Conversation

@dvg-p4

@dvg-p4 dvg-p4 commented Oct 1, 2024

Copy link
Copy Markdown

Google reverse image search suggests that Octicons were likely the original source of these now-dead images (I dug em up via the Wayback machine). Looks like they're licensed under the MIT license, same as this repo, so should be fine to use them straight from the source.

I also made them match the font height and put a bit of right-padding to make it look better.

image

@dvg-p4

dvg-p4 commented Oct 1, 2024

Copy link
Copy Markdown
Author

The lack of left-padding actually appears to be an unrelated issue that popped up when the selectize css was updated, so I'm gonna go file a bug report over on the main shiny repo for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant