Repository navigation
license-note: Make the routine step opt-in - #70
Merged
Merged
Conversation
Defaults `license-note` to false. The marker check already meant the step did nothing in a repo that had not opted in, but a repo that happens to have a LICENSE.note with matching markers should not start getting auto-commits and PR comments just because `v1` moved. Opting in is now explicit on both ends: `license-note: true` in the caller workflow, and the markers in the file.
schloerke
added a commit
to rstudio/shiny
that referenced
this pull request
Aug 17, 2026
rstudio/shiny-workflows#70 made the step opt-in, defaulting to false, so the markers in LICENSE.note are not enough on their own any more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #69: defaults the
license-noteinput tofalse.The marker check already meant the step did nothing in a repo that had not opted in — no markers, no work. But that left the opt-in implicit and one-sided: a repo that happens to have a
LICENSE.notewith matching markers would start getting auto-commits and PR comments purely becausev1moved. Turning something on for a consumer without them asking is the wrong default for this repo's@v1model.Opting in is now explicit on both ends:
plus the marker pair in
LICENSE.note.No behavior change for anyone who has not opted in, since the step was already a no-op for them. Docs updated in both READMEs.
rstudio/shiny#4426 is updated to pass
license-note: true.