Repository navigation
Fix assertion failure when marking machine stack - #137
Merged
Merged
Conversation
It's possible that a value on the machine stack appears to point into the MMTk heap. When this value is first marked during the pinning phase, it does not pin it if the object is not live. If later on, an object is evacuated into the value, then it will appear to not be pinned. Therefore, we cannot assert that target_object is actually pinned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's possible that a value on the machine stack appears to point into the MMTk heap. When this value is first marked during the pinning phase, it does not pin it if the object is not live. If later on, an object is evacuated into the value, then it will appear to not be pinned. Therefore, we cannot assert that target_object is actually pinned.