Repository navigation
Exclude flaky URI linear time test - #143
Merged
Merged
Conversation
the test_merge_path_dot_dot_removal_is_linear test bases its time limit on the CPU time of the calling thread. But the limit is actually checked against wall clock time so GC pauses count against it - despite that work happening on other threads (like the MMTk GC workers) isn't taken into account when calculating the time limit. This means that on debug builds especially, the test fails frequently because occasional GC runs use up basically all the allowed wall time. We should probably revisit this upstream, given that it's making the assumption that the mutator thread the the gc worker thread are the same, but for now let's just exclude this for MMTk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the test_merge_path_dot_dot_removal_is_linear test bases its time limit on the CPU time of the calling thread.
But the limit is actually checked against wall clock time so GC pauses count against it - despite that work happening on other threads (like the MMTk GC workers) isn't taken into account when calculating the time limit.
This means that on debug builds especially, the test fails frequently because occasional GC runs use up basically all the allowed wall time.
We should probably revisit this upstream, given that it's making the
assumption that the mutator thread the the gc worker thread are the
same, but for now let's just exclude this for MMTk.