Skip to content

Exclude flaky URI linear time test - #143

Merged
eightbitraptor merged 1 commit into
mainfrom
mvh-exclude-uri-linear-test
Nov 9, 2026
Merged

eightbitraptor merged 1 commit into
mainfrom
mvh-exclude-uri-linear-test

Conversation

@eightbitraptor

Copy link
Copy Markdown
Member

the test_merge_path_dot_dot_removal_is_linear test bases its time limit on the CPU time of the calling thread.

But the limit is actually checked against wall clock time so GC pauses count against it - despite that work happening on other threads (like the MMTk GC workers) isn't taken into account when calculating the time limit.

This means that on debug builds especially, the test fails frequently because occasional GC runs use up basically all the allowed wall time.

We should probably revisit this upstream, given that it's making the
assumption that the mutator thread the the gc worker thread are the
same, but for now let's just exclude this for MMTk.

the test_merge_path_dot_dot_removal_is_linear test bases its time limit
on the CPU time of the calling thread.

But the limit is actually checked against wall clock time so GC pauses
count against it - despite that work happening on other threads (like
the MMTk GC workers) isn't taken into account when calculating the time
limit.

This means that on debug builds especially, the test fails frequently
because occasional GC runs use up basically all the allowed wall time.

 We should probably revisit this upstream, given that it's making the
 assumption that the mutator thread the the gc worker thread are the
 same, but for now let's just exclude this for MMTk.
@eightbitraptor
eightbitraptor merged commit 87522f3 into main Nov 9, 2026
41 of 42 checks passed
@eightbitraptor
eightbitraptor deleted the mvh-exclude-uri-linear-test branch November 9, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant