Repository navigation
Separate funding tables into sections - #832
Merged
Merged
Conversation
lcnr
reviewed
Oct 26, 2026
| @@ -1233,11 +1229,13 @@ pub fn format_funding_table_grouped_by_contact(goals: &[&GoalDocument]) -> Strin | |||
| } | |||
|
|
|||
| for (contact, contact_goals) in &by_contact { | |||
Contributor
There was a problem hiding this comment.
what do you think about sorting contacts by number of goals?
Contributor
Author
There was a problem hiding this comment.
I think we should maybe remove that table altogether. Is it useful to anyone to know which contact has which goals?
In any case, I think this table should be grouped alphabetically (which it's not currently).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #goals/meta > Duplicated fundable goals in RCN/goals website @ 💬 (I didn't remove the by-contact grouping).