Repository navigation
Add safety sections to xsave-family save intrinsics - #2250
Open
kiana1kaslana wants to merge 1 commit into
Open
kiana1kaslana wants to merge 1 commit into
kiana1kaslana wants to merge 1 commit into
Conversation
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project has assigned @sayantn (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks. Why was this reviewer chosen?The reviewer was selected based on:
|
kiana1kaslana
force-pushed
the
safety-doc-xsave
branch
2 times, most recently
from
October 13, 2026 02:04
338d07f to
7607b8c
Compare
kiana1kaslana
force-pushed
the
safety-doc-xsave
branch
from
October 13, 2026 02:07
7607b8c to
92fc48e
Compare
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_xsave,_xsaveopt,_xsavec,_xsavesand their 64-bit variants are declared unsafe but carry no# Safetysection. This adds the missing sections.The size of the
XSAVEarea these instructions write depends on bothsave_mask, which selects the features to save, andXCR0, the extended control register in which the OS records the features it has enabled. The safety sections state this relationship and requiremem_addrto be valid for writes of the whole area, as well as 64-byte aligned.Doc-only change.