Skip to content

agent: fix harness open, test endpoint wrapping - #6

Merged
ryuzdev merged 1 commit into
mainfrom
openai-fix
Oct 29, 2026
Merged

ryuzdev merged 1 commit into
mainfrom
openai-fix

Conversation

@ryuzdev

@ryuzdev ryuzdev commented Oct 29, 2026

Copy link
Copy Markdown
Member

The provider switch dropped the #models/#faux assignments, failing every call closed. Restored, and extracted withEndpointModels so the behavior is unit-tested. Template check green (typecheck + bundle + 15 tests).

The provider switch replaced the registration block and lost the
this.#models/this.#faux assignments, so every call failed closed with
'harness failed to open' and no cause. The endpoint wrapping now lives in
withEndpointModels (pure, unit-tested: custom endpoint registers unknown
ids once, default stays catalog-strict, no duplicates), and assignments
sit next to the registrations.
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ryuzdev
ryuzdev marked this pull request as ready for review October 29, 2026 14:54
@ryuzdev
ryuzdev merged commit 4e8848b into main Oct 29, 2026
2 checks passed
@ryuzdev
ryuzdev deleted the openai-fix branch October 29, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant