feat: add flush method to Producer - #103
Merged
Merged
Conversation
quettabit
force-pushed
the
qb/producer-flush
branch
from
August 17, 2026 16:50
eb7de32 to
bab400a
Compare
Member
Author
|
@greptileai review pls |
quettabit
force-pushed
the
qb/producer-flush
branch
from
August 17, 2026 17:19
bab400a to
bd9a90b
Compare
Greptile SummaryAdds a public
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Sequence DiagramsequenceDiagram
participant Caller
participant Producer
participant Session
participant Drainer
Caller->>Producer: flush()
Producer->>Session: submit accumulated batch
Session-->>Producer: BatchSubmitTicket
Producer->>Drainer: wake acknowledgement task
Drainer->>Session: await ticket
Session-->>Drainer: append acknowledgement
Drainer->>Producer: resolve batch completion future
Producer-->>Caller: flush completes
Reviews (3): Last reviewed commit: "initial commit" | Re-trigger Greptile |
Member
Author
|
@greptileai addressed your comments. pls review again. |
quettabit
force-pushed
the
qb/producer-flush
branch
from
August 17, 2026 18:38
bd9a90b to
76c1ad1
Compare
Member
Author
|
@greptileai what other concerns do you have? can you pls convey em through comments on relevant blocks/lines? |
quettabit
force-pushed
the
qb/producer-flush
branch
from
August 17, 2026 19:39
76c1ad1 to
bc05aef
Compare
quettabit
marked this pull request as ready for review
August 17, 2026 19:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.