Skip to content

warnings when compiling in windows #75

Open

Description

@jpujol

I am compiling in Windows (VS2017) and I am getting warnings like

tmxpropertyset.h(66): warning C4267: 'return': conversion from 'size_t' to 'int', possible loss of data

Basically it shows a warning for all the functions that return size of a stl container, since the return value is cast to an int. Technically, size() returns a size_type.

I was going to create a PR changing all the interfaces that get the size of a container to return a size_type, but I wanted to ask for your opinion first, @sainteos

Activity

  1. sainteos commented on Oct 12, 2019

    @sainteos
    Owner

    Yeah, that change seems to make sense. If you still want to do this (sorry for the wildly late reply), go for it. If not, I can.

  2. jpujol commented on Nov 14, 2019

    @jpujol
    Author

    oh, I can do it! thanks for the reply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions