Skip to content

refactor: drop unused ExperimentalSerializationApi opt-in in GbfsJson - #184

Merged
sargunv merged 1 commit into
mainfrom
cursor/drop-experimental-json-optin-82a1
Nov 16, 2026
Merged

sargunv merged 1 commit into
mainfrom
cursor/drop-experimental-json-optin-82a1

Conversation

@sargunv

@sargunv sargunv commented Nov 16, 2026

Copy link
Copy Markdown
Owner

Description

Remove the leftover @OptIn(ExperimentalSerializationApi::class) around stable decodeEnumsCaseInsensitive in gbfs-v1 and gbfs-v2 GbfsJson.

Validation

Compiled the gbfs modules and ran mise run check plus mise run build on Linux.

AI assistance

Cursor Grok 4.6 as a Cursor Cloud Agent.

Open in Web Open in Cursor 

decodeEnumsCaseInsensitive is stable in kotlinx-serialization 1.13, so
the opt-in around it in gbfs-v1 and gbfs-v2 is no longer required.

Co-authored-by: Sargun Vohra <sargunv@users.noreply.github.com>
@sargunv
sargunv marked this pull request as ready for review November 16, 2026 03:07
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T03:07:56.863009Z cfb3cb3 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@greptile-apps

greptile-apps Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge; no actionable issues were found.

Summary

Removes the ExperimentalSerializationApi imports and @OptIn annotations from GbfsJson in gbfs-v1 and gbfs-v2.

  • The GBFS v1 and v2 configs drop the enum-matching opt-in.

Reviews (1) · Last reviewed commit: "refactor: drop unused ExperimentalSerial..." · Reviewed by Greptile

@sargunv
sargunv merged commit 86dead2 into main Nov 16, 2026
5 checks passed
@sargunv
sargunv deleted the cursor/drop-experimental-json-optin-82a1 branch November 16, 2026 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants