Match EEGLAB's probability loop in pop_autorej - #325
Open
arnodelorme wants to merge 1 commit into
Open
Conversation
|
Claude encountered an error after 0s —— View job I'll analyze this and get back to you. |
Collaborator
Author
|
🤖 ## Code review
BlockingNone. ImportantNone. NitsNone. Test gapsNone. Ten parametrized cases cover the raise, reject, and prune phases in both channel and component mode, with reference values from EEGLAB parity notesCompared against
Verification on develop (b377c3f) + this branch (28b5221) + #323: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run the pop_autorej probability loop like EEGLAB: a pass rejects only when fewer than maxrej percent of the epochs are flagged, and once nothing is flagged the threshold walks back toward 5 s.d. for up to eight pruning rounds instead of stopping at the first clean pass. Adds a parity test with reference rejections from tests/matlab/pop_autorej_reference.m (EEGLAB develop aadfd19a7). The final kurtosis pass stays mode-aware; EEGLAB skips it in channel mode because it reads icarejkurt.