Repository navigation
Phase 6: MINGLE multilevel agglomerative edge bundling - #24
Merged
Merged
Conversation
Add src/mingle.cpp (mingle_iter) and the exported edge_bundle_mingle(). Edges are grouped bottom-up: two bundles merge when routing them through shared geometric-median meeting points reduces total ink; the merge tree is rendered as a per-edge control polyline through its chain of meeting points, relaxed toward the straight line by bundle_strength. kNN over edges is brute force (O(E^2)) so no new dependency is required; a kd-tree can be substituted later for very large graphs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seventh phase (see
_docs/REFACTORING-PLAN.md). Adds the scalability-oriented bundler none of the existing four cover.What
src/mingle.cpp(mingle_iter) + new exportedge_bundle_mingle(object, xy, segments = 50, bundle_strength = 0.9).bundle_strength.Deviation from the plan (dependency)
kNN over edges is brute force (O(E²)), so no new dependency was added. This trades the paper's O(E log E) scalability for zero deps and full correctness at interactive sizes; a kd-tree can be swapped in later. Documented in the roxygen + plan.
Tests
Contract (
x,y,index,group, 50 pts/edge), endpoints fixed, parallel edges bundle (mid-spread 5 → ~0.5),bundle_strength = 0→ straight, single edge stays straight.FAIL 0 | PASS 82.Note
Not visually validated this session.
🤖 Generated with Claude Code