Repository navigation
Phase 7: deprecate metro_multicriteria() - #25
Merged
Merged
Conversation
Soft-deprecate metro_multicriteria() in favour of graphlayouts::layout_as_metromap(), which now provides this layout. The function still works but emits a deprecation warning; roxygen, NEWS and tests updated accordingly. Full removal of the metro C++ and exports is left for a later release. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eighth phase (see
_docs/REFACTORING-PLAN.md, §7.2). Small and safe.What
metro_multicriteria()now emits.Deprecated(msg = "... use graphlayouts::layout_as_metromap() instead."). The metro-map multicriteria layout (Stott et al. 2010) is now provided bygraphlayouts::layout_as_metromap(), so it no longer belongs here.Deferred (a later release)
Removing
R/metro_multicriteria.R,src/metroLayout.cpp, thecriterion_*/layout_as_metro_iterRcpp exports, and possibly the duplicatedmetro_berlindataset — this also retires the unimplementedcriterion_line_straightness()stub.Result
FAIL 0 | WARN 0 | PASS 82.🤖 Generated with Claude Code