Spelling fixes by jsoref · Pull Request #1926 · schwabe/ics-openvpn

jsoref · 2026-09-14T04:31:12Z

Upgrade Actions:

Use checkout v7
Use setup-java v6
Use setup-android v4
Use upload-artifact v7
Use codeql-action v4

Spelling:

(tls-cypher suites) DEFAULT:!EXP:!PSK:!SRP:!kRSA
; otherwise,
a
accidentally
added
an
api....vpn
appropriate
arbitrary
arithmetic
assume
authentication
authenticator
authentication
auto
battery_consumption
between
bionic
building
building_configuration
certificate
certificates
changes
checkmarshmallowfileimporterror
checktorreceiver
cipher
cipher_dialog_message
compatibility
connect_slider
connected
constitutes
contributor
corresponds
credentials
custom_connection_options_warning
derivative
description
different
discard
dnssec
ellipse
embed
exception
example
executesucmd
fall back
first
generate
getlatestdump
guarantee
have been
idea
in case,
internet-archive: tcp-tcp.html
iterated
limits
lowercase
managed
management
managementcommand
marsh
marshaledbytes
marketing
marshalandback
marshaling
marshalstring
matched
need
net
noreplyyet
notification
notification_title
notification_title_notconnect
officialdebugkey
officialkey
onlyfindfileandnullonnotfound
openvpn_copyright
ovpn3cli
parameters
parse
permission_hint
persistent
pkcs
please note
processpwfailed
profilename
reading
reasons
reciever
relevant
remember the
resource
response
separate
setconnectedvpnprofiledisconnected
shouldbeconnected
sliders
ssaid
state
successfully
symptom
test_algorithms
testmarshal
testmarshalargs
testmarshalstring
that
time_period_minutes
to
troublesome
unique
unknown
unmarshal
update_ext_alias
verbositylevel
visibility
vpn_authentication
warning_custom
when
workaround
workaround,
worked around
would

Spelling (German):

ciphers
ip carriers

Spelling (Spanish):

aplicación
autenticación
certificación
conexión
configuración
excepción
selección
sincronización
y
wifi

Spelling (Italian):

password

Spelling (Romanian):

Use Romanian [st]-commas tr/şŞţŢ/șȘțȚ/
clipboard
tls
status

Spelling (Chinese):

tls

The commits are individually available in: https://github.com/jsoref/ics-openvpn/commits/spell-check-with-spelling

jsoref

This project let me significantly improve my handling of foreign languages (whether or not the changes are taken).

jsoref · 2026-09-14T04:33:08Z

                if (currentNet.getFirstAddress().equals(nextNet.getFirstAddress()) && currentNet.networkMask >= nextNet.networkMask) {
                    if (currentNet.included == nextNet.included) {
-                        // Included in the next next and same type
+                        // Included in the next net and same type


This was flagged by a duplicate word check. I'm guessing that it's supposed to correspond to the variable name...

jsoref · 2026-09-14T04:33:54Z


    @SuppressLint("HardwareIds")
-    public static String getFakeMacAddrFromSAAID(Context c) {
+    public static String getFakeMacAddrFromSSAID(Context c) {


ssaid appears to be the term of art: https://stackoverflow.com/questions/58727002/android-id-ssaid-to-track-devices-in-android-10-and-above

jsoref · 2026-09-14T04:34:32Z



-}
+}


I'm not sure what caused this change, but git/github don't like missing EOL at EOF...

jsoref · 2026-09-14T04:36:26Z


        /* Samsung has decided to do something strange, on stock Android GET_CONTENT opens the document UI */
-        /* fist try with documentsui */if (Build.VERSION.SDK_INT <= Build.VERSION_CODES.N) i.setPackage(
+        /* first try with documentsui */if (Build.VERSION.SDK_INT <= Build.VERSION_CODES.N) i.setPackage(


I spotted this while looking for other things...

But, it appears to be popular: https://github.com/search?q=%22fist+try%22&type=code

jsoref · 2026-09-14T04:38:58Z

    <string name="version_and_later">%s وما بعدها</string>
    <string name="tls_cipher_alert_title">فشل الاتصالات مع SSL23_GET_SERVER_HELLO: فشل مصافحة تنبيه sslv3</string>
-    <string name="tls_cipher_alert">تستخدم إصدارات OpenVPN الأحدث لنظام Android (0.6.29 / مارس 2015) افتراضيًا أكثر أمانًا لمجموعات التشفير المسموح بها (tls-cipher \"DEFAULT:! EXP:! PSK:! SRP:! kRSA\"). لسوء الحظ ، فإن حذف مجموعات التشفير الأقل أمانًا ومجموعات التشفير ، لا سيما حذف مجموعات التشفير التي لا تدعم Perfect Forward Secrecy (Diffie-Hellman) يسبب بعض المشكلات. يحدث هذا عادةً بسبب محاولة حسنة النية ولكنها سيئة التنفيذ لتعزيز أمان TLS من خلال تعيين tls-cipher على الخادم أو بعض أنظمة التشغيل المدمجة مع SSL (مثل MikroTik).\nلحل هذه المشكلة ، قم بتعيين إعدادات tls-cipher على الخادم على افتراض افتراضي مثل tls-cipher \"DEFAULT:! EXP:! PSK:! SRP:! kRSA\". لحل المشكلة على العميل ، قم بإضافة الخيار الافتراضي tls-cipher DEFAULT على عميل Android.</string>
+    <string name="tls_cipher_alert">تستخدم إصدارات OpenVPN الأحدث لنظام Android (0.6.29 / مارس 2015) افتراضيًا أكثر أمانًا لمجموعات التشفير المسموح بها (tls-cipher \"DEFAULT:!EXP:!PSK:!SRP:!kRSA\"). لسوء الحظ ، فإن حذف مجموعات التشفير الأقل أمانًا ومجموعات التشفير ، لا سيما حذف مجموعات التشفير التي لا تدعم Perfect Forward Secrecy (Diffie-Hellman) يسبب بعض المشكلات. يحدث هذا عادةً بسبب محاولة حسنة النية ولكنها سيئة التنفيذ لتعزيز أمان TLS من خلال تعيين tls-cipher على الخادم أو بعض أنظمة التشغيل المدمجة مع SSL (مثل MikroTik).\nلحل هذه المشكلة ، قم بتعيين إعدادات tls-cipher على الخادم على افتراض افتراضي مثل tls-cipher \"DEFAULT:!EXP:!PSK:!SRP:!kRSA\". لحل المشكلة على العميل ، قم بإضافة الخيار الافتراضي tls-cipher DEFAULT على عميل Android.</string>


While working on support for foreign languages, I ran across these items... I'm fairly certain that the underlying content needs a "localization note" since it appears that various localizations have thoroughly corrupted this content (in a number of different ways...).

jsoref · 2026-09-14T04:41:11Z

-    <string name="building_configration">Construyendo configuracion&#8230;</string>
-    <string name="netchange_summary">Activando esta opción forzara una reconexión si el estado de la red es cambiado (Ej. De/hacia WIFi
+    <string name="building_configuration">Construyendo configuracion&#8230;</string>
+    <string name="netchange_summary">Activando esta opción forzara una reconexión si el estado de la red es cambiado (Ej. De/hacia WiFi


WIFi is just wrong.

jsoref · 2026-09-14T04:42:11Z

    <string name="ab_only_cidr">Android sólo admite rutas CIDR a la VPN. Desde rutas no CIDR casi nunca se usan, OpenVPN para Android utilizará un / 32 para las rutas que no son CIDR y emitir una advertencia.</string>
    <string name="ab_proxy">Android seguirá utilizando la configuración del proxy especificados para la conexión / Wi-Fi móvil cuando no están definidos los servidores DNS. OpenVPN para Android le advertirá sobre esto en el registro.<p>Cuando una VPN establece un servidor DNS Android no lo hará un proxy. No hay ninguna API para configurar un proxy para una conexión VPN.</p></string>
-    <string name="ab_not_route_to_vpn">La IP del cliente configurado y las IPs en su máscara de red no se enrutan a la VPN. OpenVPN soluciona este error al agregar explícitamente una ruta que corrosponds a la IP del cliente y su máscara de red</string>
+    <string name="ab_not_route_to_vpn">La IP del cliente configurado y las IPs en su máscara de red no se enrutan a la VPN. OpenVPN soluciona este error al agregar explícitamente una ruta que corresponds a la IP del cliente y su máscara de red</string>


corresponde would be the correct word, but that's too much of a change.

jsoref · 2026-09-14T04:45:39Z

    <string name="address">Adresa server:</string>
    <string name="port">Port server:</string>
-    <string name="location">Locaţie</string>
+    <string name="location">Locație</string>


This was a fun lesson, Romanian wants commas for s/t, not cedilla. The localization is inconsistent.

jsoref · 2026-09-14T04:47:21Z

    <string name="cancel_connection_query">断开连接的VPN/取消连接尝试？</string>
    <string name="remove_vpn">删除VPN</string>
-    <string name="check_remote_tlscert">检查服务器是否使用 TLS 服务器端扩展 (--remote-cert-tlsserver server)</string>
+    <string name="check_remote_tlscert">检查服务器是否使用 TLS 服务器端扩展 (--remote-cert-tls server)</string>


fun error (this was the only real change to this locale -- I don't have a "dictionary" for Chinese ... I've asked around a bit but didn't get beyond that point...

Actions: - Use checkout v7 - Use setup-java v6 - Use setup-android v4 - Use upload-artifact v7 - Use codeql-action v4 Spelling: - (tls-cypher suites) DEFAULT:!EXP:!PSK:!SRP:!kRSA - ; otherwise, - a - accidentally - added - an - api....vpn - appropriate - arbitrary - arithmetic - assume - authentication - authenticator - authentication - auto - battery_consumption - between - bionic - building - building_configuration - certificate - certificates - changes - checkmarshmallowfileimporterror - checktorreceiver - cipher - cipher_dialog_message - compatibility - connect_slider - connected - constitutes - contributor - corresponds - credentials - custom_connection_options_warning - derivative - description - different - discard - dnssec - ellipse - embed - exception - example - executesucmd - fall back - first - generate - getlatestdump - guarantee - have been - idea - in case, - internet-archive: tcp-tcp.html - iterated - limits - lowercase - managed - management - managementcommand - marsh - marshaledbytes - marketing - marshalandback - marshaling - marshalstring - matched - need - net - noreplyyet - notification - notification_title - notification_title_notconnect - officialdebugkey - officialkey - onlyfindfileandnullonnotfound - openvpn_copyright - ovpn3cli - parameters - parse - permission_hint - persistent - pkcs - please note - processpwfailed - profilename - reading - reasons - reciever - relevant - remember the - resource - response - separate - setconnectedvpnprofiledisconnected - shouldbeconnected - sliders - ssaid - state - successfully - symptom - test_algorithms - testmarshal - testmarshalargs - testmarshalstring - that - time_period_minutes - to - troublesome - unique - unknown - unmarshal - update_ext_alias - verbositylevel - visibility - vpn_authentication - warning_custom - when - workaround - workaround, - worked around - would Spelling (German): - ciphers - ip carriers Spelling (Spanish): - aplicación - autenticación - certificación - conexión - configuración - excepción - selección - sincronización - y - wifi Spelling (Italian): - password Spelling (Romanian): - Use Romanian [st]-commas tr/şŞţŢ/șȘțȚ/ - clipboard - tls - status Spelling (Chinese): - tls Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref · 2026-09-14T04:53:00Z

this is a refresh of Spelling #1143

schwabe · 2026-10-07T09:20:21Z

I cherry picked your commit with the following changes:

do not change files in the bundled lzo library
do not mix changing github action with spelling fixes

jsoref commented Sep 14, 2026

View reviewed changes

jsoref force-pushed the spelling branch from b33d265 to 65482de Compare September 14, 2026 04:50

schwabe closed this Oct 7, 2026

jsoref deleted the spelling branch October 7, 2026 14:33

Navigation Menu

Repository navigation

Spelling fixes - #1926

Spelling fixes#1926
jsoref wants to merge 1 commit into
schwabe:masterfrom
jsoref:spelling

jsoref commented Sep 14, 2026

Uh oh!

jsoref left a comment

Uh oh!

jsoref Sep 14, 2026

Uh oh!

jsoref Sep 14, 2026

Uh oh!

jsoref Sep 14, 2026

Uh oh!

jsoref Sep 14, 2026

Uh oh!

jsoref Sep 14, 2026

Uh oh!

jsoref Sep 14, 2026

Uh oh!

jsoref Sep 14, 2026

Uh oh!

Uh oh!

jsoref Sep 14, 2026

Uh oh!

jsoref Sep 14, 2026

Uh oh!

jsoref commented Sep 14, 2026

Uh oh!

schwabe commented Oct 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jsoref commented Sep 14, 2026

Uh oh!

jsoref left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jsoref commented Sep 14, 2026

Uh oh!

schwabe commented Oct 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants