Skip to content

[ESSDIFFRACTION] BEER improvements - #704

Open
jokasimr wants to merge 6 commits into
mainfrom
improve-beer
Open

[ESSDIFFRACTION] BEER improvements#704
jokasimr wants to merge 6 commits into
mainfrom
improve-beer

Conversation

@jokasimr

@jokasimr jokasimr commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Main changes are:

  • Adds the modulation chopper modes to the list of chopper settings.
  • Uses chopper parameters instead of mcstas specific parameters in modulation workflow, making it more ready for real data.
  • Simplifies the McStas data loader - it needed some refactoring.

@github-actions github-actions Bot added the essdiffraction Issues for essdiffraction. label Aug 14, 2026
@github-actions github-actions Bot changed the title BEER improvements [ESSDIFFRACTION] BEER improvements Aug 14, 2026
@jokasimr

jokasimr commented Aug 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

The changes look very scary because of the lockfile, the non-lockfile changes are something like +850 -950.

@jokasimr
jokasimr requested a review from nvaytet August 14, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nvaytet nvaytet Awaiting requested review from nvaytet

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

essdiffraction Issues for essdiffraction.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jokasimr