Skip to content

Validate that the folder exist when initializing the ResultExplorer on AWS #453

Description

@R-Palazzo

Environment Details

  • SDGym version: 0.10.0

Error Description

Currently, when we initialize a ResultsExplorer with an invalid local folder name, we correctly get an error:

result_explorer = ResultsExplorer('Fake/')

ValueError: The provided path 'Fake/' is not a valid local directory.

However, when the path points to an AWS folder, no validation is performed, and no error is raised. For consistency, we should also validate AWS result folders and raise an error if they don’t exist.

Steps to reproduce

result_explorer = ResultsExplorer(
    's3://sdgym-benchmark/Fake/',
    aws_access_key_id=aws_access_key_id,
    aws_secret_access_key=aws_secret_access_key
)

No activity

Activity on this issue will appear here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions