Complete PLT-910: remove legacy wasm dual metrics - #4075
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4075 +/- ##
==========================================
- Coverage 61.23% 60.16% -1.08%
==========================================
Files 2177 2069 -108
Lines 190632 178111 -12521
==========================================
- Hits 116729 107156 -9573
+ Misses 62892 60986 -1906
+ Partials 11011 9969 -1042
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
PR SummaryLow Risk Overview Duration recorders no longer call Reviewed by Cursor Bugbot for commit ce4cf43. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Clean removal of the duplicated telemetry/go-metrics wasm emission: the OTel histograms already cover every removed timing/gas signal, the contract_address-labeled series that drove the cardinality issue are gone, no callers or imports are left dangling, and the removed contractAddress parameter has no remaining users. Only note is that a rationale comment guarding against re-adding a per-contract attribute was deleted along with the legacy code.
Findings: 0 blocking | 1 non-blocking | 1 posted inline
Blockers
- None at the file/PR level.
Non-blocking
- None at the file/PR level.
- 1 suggestion(s)/nit(s) flagged inline on specific lines.
| // contract_address omitted on the OTel histogram: unlike the legacy Prometheus sink, the | ||
| // OTel SDK has no series expiration, so a per-contract label here would retain one series | ||
| // per distinct contract address queried for the process lifetime. | ||
| func recordContractQuerySmartGasUsed(ctx context.Context, gasUsed uint64) { |
There was a problem hiding this comment.
[suggestion] The deleted comment carried a load-bearing constraint, not just legacy context: "the OTel SDK has no series expiration, so a per-contract label here would retain one series per distinct contract address queried for the process lifetime." That is exactly the cardinality problem this PR (CON-336/337) closes, and with the comment gone nothing stops the next change from re-adding a contract_address attribute to this histogram. Consider keeping a one-line version of the rationale on recordContractQuerySmartGasUsed (or on the contractQuerySmartGasUsed histogram definition), dropping only the reference to the removed Prometheus sink.
Summary
Finishes the wasm keeper OTel migration (PLT-910) by removing legacy
telemetry/go-metricsemission that duplicated the OpenTelemetry histograms already in place.telemetry.MeasureSincefallbacks from contract duration recorders (instantiate, execute, migrate, sudo, query-smart, query-raw).Also addresses CON-336 and CON-337 unbounded cardinality issue.
Important:
This PR should only be merged after release 6.7 landed, since its equivalent Otel metrics are only included in release 6.7.
Also there should be a corresponding Platform dashboard migration PR.