Skip to content
This repository was archived by the owner on Oct 5, 2019. It is now read-only.
This repository was archived by the owner on Oct 5, 2019. It is now read-only.

Remove legacy picker code #156

Description

@jespirit

The directive still references the picker object that is legacy code dating back to Bootstrap-Slider version 3.0.0

Current usage in this AngularJS directive

// check if slider jQuery plugin exists
if (typeof window.$ !== 'undefined' && typeof $.fn === 'object' && $.fn.slider) {
    // adding methods to jQuery slider plugin prototype
    $.fn.slider.constructor.prototype.disable = function () {
        this.picker.off();
    };
    $.fn.slider.constructor.prototype.enable = function () {
        this.picker.on();
    };
}

Legacy code

if (parent.hasClass('slider') === true) {
    updateSlider = true;
    this.picker = parent;
} else {
    this.picker = $('<div class="slider">'+
                        '<div class="slider-track">'+
                            '<div class="slider-selection"></div>'+
                            '<div class="slider-handle"></div>'+
                            '<div class="slider-handle"></div>'+
                        '</div>'+
                        '<div class="tooltip"><div class="tooltip-arrow"></div><div class="tooltip-inner"></div></div>'+
                    '</div>')
                        .insertBefore(this.element)
                        .append(this.element);
}

Activity

  1. vincentfullstack commented on Feb 22, 2019

    @vincentfullstack
    Collaborator

    I will do it.

  2. seiyria commented on Feb 22, 2019

    @seiyria
    Owner

    Always happy to add maintainers over here - I don't use this anymore and will not be coming back to it. Feel free to put up a PR!

  3. added a commit that references this issue on Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions