π·ββοΈ Follow the default branch rename to main - #184
Merged
Merged
Conversation
At the moment, our workflow only triggers on pushes and pull requests targeting `master`, and the coverage badge is pinned to `?branch=master`. Since the default branch is now `main`, those filters match nothing. CI doesn't fail on `main`; it simply never runs, and with no required checks that's easy to miss entirely. This change points both triggers at `main` and updates the Coveralls badge. Note that it had to land *after* the rename rather than before: for a `pull_request` event GitHub reads the workflow file from the merge ref but matches `branches` against the *base* branch, so this very commit would have gone untested on a PR still targeting `master`. The `Test` badge only moves to the current `actions/workflows/test.yml/badge.svg` form, without a `?branch=` parameter: that form already tracks whatever the default branch is, so there's no reason to hard-code a name here and have to revisit it again. Coveralls is different, since its own idea of our default branch is separate from GitHub's and needs setting by hand, so that badge stays explicit. `workflow_dispatch`'s `branches` filter is dropped rather than renamed, since the event has no such key in the Actions schema and GitHub has always ignored it. Finally, the `coverallsapp/github-action@master` pins are deliberately left untouched. That is *not* because `master` is still their default branch β it isn't, they moved to `main` some time ago β but because their `master` is an abandoned ref last touched in April 2023, and retargeting it at `main` here would silently pull in three years of unreviewed third-party changes. Pinning it to `v2` or a SHA wants to be its own change, with its own testing. π€ Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
alecgibson
force-pushed
the
rename-default-branch
branch
from
September 7, 2026 11:01
b472fb6 to
3593efd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, our workflow only triggers on pushes and pull requests targeting
master, and the coverage badge is pinned to?branch=master.Since the default branch is now
main, those filters match nothing. CI doesn't fail onmain; it simply never runs, and with no required checks that's easy to miss entirely.This change points both triggers at
mainand updates the Coveralls badge. Note that it had to land after the rename rather than before: for apull_requestevent GitHub reads the workflow file from the merge ref but matchesbranchesagainst the base branch, so this very commit would have gone untested on a PR still targetingmaster.The
Testbadge only moves to the currentactions/workflows/test.yml/badge.svgform, without a?branch=parameter: that form already tracks whatever the default branch is, so there's no reason to hard-code a name here and have to revisit it again. Coveralls is different, since its own idea of our default branch is separate from GitHub's and needs setting by hand, so that badge stays explicit.workflow_dispatch'sbranchesfilter is dropped rather than renamed, since the event has no such key in the Actions schema and GitHub has always ignored it.Finally, the
coverallsapp/github-action@masterpins are deliberately left untouched. That is not becausemasteris still their default branch β it isn't, they moved tomainsome time ago β but because theirmasteris an abandoned ref last touched in April 2023, and retargeting it atmainhere would silently pull in three years of unreviewed third-party changes. Pinning it tov2or a SHA wants to be its own change, with its own testing.π€ Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com