osp_verification: stabilize LB tests in periodic CI jobs - #41
Conversation
57dd1c2 to
9ca86a7
Compare
72889ca to
cf394be
Compare
| done < {{ tests_to_run_path }} | ||
| python3 "{{ openstack_test_ote_resolve_script }}" junit \ | ||
| "{{ openstack_test_log_path }}" "{{ openstack_test_junit_path }}" || py_exit=$? | ||
| exit ${run_exit:-${py_exit:-0}} |
There was a problem hiding this comment.
The serial OTE runner initializes run_exit=0, then exits with:
exit ${run_exit:-${py_exit:-0}}
If the JUnit resolver fails, py_exit is ignored because run_exit is already set to 0. The Ansible task therefore succeeds even though JUnit generation failed. The exit status
should preserve either failure, for example:
exit "${run_exit:-${py_exit:-0}}"
with run_exit initialized only when needed, or explicitly combine both statuses.
There was a problem hiding this comment.
Fixed in 64fc83c. The serial runner now initializes py_exit=0 and exits non-zero if either run-test or the junit resolver fails.
There was a problem hiding this comment.
Same comment as in line 189
There was a problem hiding this comment.
Fixed in 64fc83c for the batch run-test path as well (same combined exit logic).
|
Ready for another review pass at 64fc83c. Summary since the last round:
serval71 manual lb_tests at bb99bec: isolated 4/4, main amphora 0 failures, OVN 0 failures. ci-framework-testproject branch osp-verification-pr41-serval71 triggers end-to-end Zuul on serval71 with refs/pull/41/head.: https://gitlab.cee.redhat.com/ci-framework/ci-framework-testproject/-/merge_requests/2711 |
Run lb_tests before openstack_test, keep [lb] out of the default suite, and run Amphora/OVN LB OTE serially with provider allowlists. Split Amphora into isolated, remaining, and late sourceRanges phases; gate guest cleanup; fix multi-file blocklist truncate and serial OTE exit status. Co-authored-by: Cursor <cursoragent@cursor.com>
b1076d7 to
69626c9
Compare
tusharjadhav3302
changed the title
|
Ready for another review pass at 69626c9 (supersedes the earlier note @ 64fc83c). Summary since that round:
serval71 manual ci-framework-testproject branch osp-verification-pr41-serval71 triggers end-to-end Zuul on serval71 with refs/pull/41/head: https://gitlab.cee.redhat.com/ci-framework/ci-framework-testproject/-/merge_requests/2711 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekuris-redhat The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
Summary
Stabilize LB-related failures in
osp_verification*periodic jobs:lb_testsbeforeopenstack_testin job definitions andplaybooks/ocp_testing.yaml.[lb]specs from the defaultopenstack_teststage; LB coverage stays inlb_tests.run-testper case) with Amphora/OVN allowlists (no stdin batch parallelization).lb_tests:loadBalancerSourceRangesunder Amphora (before OVN), so OCCM is less contended when clearingallowed_cidrslb_tests(OSASINFRA-2412).filter_tests_listallowlist+blocklist; truncate allow/block txt once before multi-file YAML conversion.lb_tests_guest_cleanup(defaultfalse); serial OTE fails ifrun-testor junit resolver fails.Related: OSPRH-34941 · pairs with openshift/openstack-test#320 (Amphora per-spec teardown + EqualFold sourceRanges wait).
Test plan
lb_tests@ tip (69626c9/ late sourceRanges phase) + openstack-test PR #320: isolated 3/0 fail, amphora phase 2 0 fail, late sourceRanges PASS (ACL allow-all ~2s), OVN 0 failosp_verification_5.1_nightly.yamlon serval71 withrefs/pull/41/head