Tighten API key and failure-path standards - #13
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This was referenced Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three gaps in
STANDARDS.mdthat both open example PRs (#10, #12) hit independently..env.examplemust have empty values. The standard said to put example values in it. A non-emptyplaceholder passes a falsiness check for a missing key, so the example dies later on an opaque API 401
instead of printing its own message — the failure the standard says to give the most attention to.
c608358already fixed this ininstagram-ai-video; this makes it the rule. A comment above eachvariable carries the documentation the placeholder was there for.
The README must say how to load
.env._templateexpectsexport,instagram-ai-videousesnode --env-file=.env, and neither open PR mentions the file at all, so users copy it and nothing readsit.
exportis the default because it works in both languages;--env-fileneeds Node 20.6, which theexisting rule already forbids without a
package.jsonto pinengines.Python: catch
Exception. Both open PRs enumerated exception tuples and both missedAttributeError; one also missesKeyboardInterruptin a ten-minute poll loop. Each prints a traceback,which the standard forbids. The narrow catch buys nothing when the requirement is one line and a non-zero
exit.
Check 5 names its inputs. It said to compare the two language files. Both PRs' authors clearly
compared the happy path; every divergence found was in a failure path.
Not included: a mandated network-disconnection test. The requirement to handle network failure stays in
the Failures section; testing it stays with review.
Verify:
npx prettier@3 --check STANDARDS.md. Prose follows the file's own Simplified Technical Englishrules.