rust(feat): add sift-cli agent lifecycle for Claude and Codex - #704
Merged
Conversation
This was referenced Jul 30, 2026
evan-sift
marked this pull request as ready for review
July 30, 2026 16:35
evan-sift
force-pushed
the
rust/cli-agent-claude-codex
branch
from
July 30, 2026 22:39
c57395b to
81b3cfc
Compare
lineville
reviewed
Jul 30, 2026
evan-sift
force-pushed
the
rust/cli-agent-claude-codex
branch
from
July 31, 2026 01:01
81b3cfc to
9765e68
Compare
lineville
previously approved these changes
Jul 31, 2026
evan-sift
marked this pull request as draft
July 31, 2026 16:35
evan-sift
marked this pull request as ready for review
July 31, 2026 16:35
evan-sift
force-pushed
the
rust/cli-agent-claude-codex
branch
from
July 31, 2026 17:19
9765e68 to
0b8fab0
Compare
lineville
approved these changes
Jul 31, 2026
evan-sift
force-pushed
the
rust/cli-agent-claude-codex
branch
from
July 31, 2026 18:09
0b8fab0 to
1e34e5b
Compare
evan-sift
force-pushed
the
rust/cli-agent-claude-codex
branch
from
July 31, 2026 18:27
1e34e5b to
c33ac22
Compare
Add `sift-cli agent install|update|doctor|uninstall`, replacing the removed project-scoped skill writer with four stateless, user-scoped commands. State is derived from the installed files and each client's own MCP config, so there is no state file to drift. Register through each client's native CLI (`claude mcp`, `codex mcp`) rather than editing their config files. Codex registrations are only treated as Sift-managed when both the transport and the surrounding metadata match what this CLI writes, so a hand-tuned entry is reported as a conflict instead of being silently replaced. Native replacement is remove-then-add, and a failed add restores the previous entry. Install and update preflight every target and refuse to touch an unmanaged same-name skill or MCP entry. Skill install mirrors the embedded bundle exactly, so files a previous release left behind are removed. Registrations default to read-only; update preserves whatever mode is already installed and rejects a mixed fleet rather than picking for the user. Point the MCP server's instructions and destructive-tool refusal at these commands, and make `agent update` refuse to run on an outdated CLI, printing the installer for the newer release. Release lookup now skips drafts and prereleases. Rollback of a partial multi-client install is covered by the native replacement test here; the cross-client transaction tests arrive with the JSON-backed clients, which can be driven without a fake process runner.
evan-sift
force-pushed
the
rust/cli-agent-claude-codex
branch
from
July 31, 2026 18:41
c33ac22 to
7f0b6a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds
sift-cli agent install|update|doctor|uninstall, replacing the removed project-scoped skill writer with four stateless, user-scoped commands. State is derived from the installed files and each client's own MCP config, so there is no state file to drift.Registers through each client's native CLI (
claude mcp,codex mcp) rather than editing their config files. A Codex registration counts as Sift-managed only when both the transport and the surrounding metadata match what this CLI writes, so a hand-tuned entry is reported as a conflict instead of being silently replaced. Native replacement is remove-then-add, and a failed add restores the previous entry.Install and update preflight every target and refuse to touch an unmanaged same-name skill or MCP entry. Skill install mirrors the embedded bundle exactly, so files a previous release left behind are removed. Registrations default to read-only; update preserves whatever mode is installed and rejects a mixed fleet rather than choosing for the user.
Points the MCP server's instructions and destructive-tool refusal at these commands, and makes
agent updaterefuse to run on an outdated CLI, printing the installer for the newer release. Release lookup now skips drafts and prereleases.Verification
cargo fmt --check --all,cargo clippy --all-features,cargo test --all-featurescmd::agenttests plus thecmd::versionrelease-filter testNote for reviewers
Rollback of a partial multi-client install is covered here by the native replacement test. The cross-client transaction tests arrive with the JSON-backed clients in the next PR, which can be driven directly without a fake process runner.