Repository navigation
fix(security): require authentication by default for HTTP mode (GHSA-4jj7-7g54-cqrv) - #20
Closed
sandiyochristan wants to merge 1 commit into
Closed
sandiyochristan wants to merge 1 commit into
sandiyochristan wants to merge 1 commit into
Conversation
…4jj7-7g54-cqrv) Auto-generate bearer authentication keypair and access token when starting the server in HTTP or hybrid mode without prior key configuration. Provide explicit --allow-unauthenticated flag with warning banner for unauthenticated local setups.
Owner
|
Thanks, but this is documented behavior rather than a vulnerability. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remediates GHSA-4jj7-7g54-cqrv (CWE-306) by ensuring authentication is enabled by default when running Magg in HTTP or hybrid mode (
magg serve --http/--hybrid).Problem
Previously, when running
magg serve --httpwithout prior manual key configuration viamagg auth, the server started withauth=None. In this state, unauthenticated network clients could invokeadd_serverwith arbitrary commands, leading to remote code execution.Solution
--httpor--hybridmode without existing bearer keys:key_pathif it does not already exist.ServerManager's FastMCP auth provider, protecting all tool calls.--allow-unauthenticatedflag for operators who explicitly want unauthenticated HTTP access, accompanied by a prominent security warning banner.--allow-unauthenticatedmode.