Talk to Android devices through the adb binary - #2565
Open
soulgalore wants to merge 2 commits into
Open
Conversation
adbkit was only used for a handful of shell, pull, push, forward and reboot calls, while the same file already shelled out to adb for port forwards and device state. Keeping both meant every install paid for adbkit and its transitive packages, inclrge, to reach an adb serveradbkit was only used for push, forward and rebootcalls, while the same fildb for port forwards anddevice state. Keeping bot for adbkit and itstransitive packages, including bluebird and node-forge, to reach an adb server that requires the adb binary to be installed anyway. Using the binary directly removes that cost and drops the stream plumbing around each shell commandadbkit's semantics: mergedoutput and no rejection on a non-zero exit, so callers that inspect the output keep working. Co-Authored-By: Claude Who? Change-Id: Ifdda93573e444e030f7d57254e7f834ac8c7ecb0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adbkit was only used for a handful of shell, pull, push, forward and reboot calls, while the same file already shelled out to adb for port forwards and device state. Keeping both meant every install paid for adbkit and its transitive packages, inclrge, to reach an adb serveradbkit was only used for push, forward and rebootcalls, while the same fildb for port forwards anddevice state. Keeping bot for adbkit and itstransitive packages, including bluebird and node-forge, to reach an adb server that requires the adb binary to be installed anyway. Using the binary directly removes that cost and drops the stream plumbing around each shell commandadbkit's semantics: mergedoutput and no rejection on a non-zero exit, so callers that inspect the output keep working.
Co-Authored-By: Claude Who?