Repository navigation
Fix the Windows and upload CI jobs - #4897
Merged
Merged
Conversation
The Windows job installs FFmpeg from BtbN's rolling "latest" release, which only keeps the two newest branches. 7.1 dropped out of it, so the download 404s on every run. Move to 8.1 and the current action release, and leave a note that this needs a bump roughly once a year. The upload job tested S3 against MinIO, but MinIO archived the open source project and pulled its images from Docker Hub, so the compose setup can no longer start. The test only needs an endpoint that accepts an upload, so replace it with adobe/s3mock: a small Apache-2 mock that pre-creates the bucket from an env var and accepts any credentials, which also removes the mc sidecar and the compose file. Co-authored-by: Claude Fable 5.1 noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows job installs FFmpeg from BtbN's rolling "latest" release, which only keeps the two newest branches. 7.1 dropped out of it, so the download 404s on every run. Move to 8.1 and the current action release, and leave a note that this needs a bump roughly once a year.
The upload job tested S3 against MinIO, but MinIO archived the open source project and pulled its images from Docker Hub, so the compose setup can no longer start. The test only needs an endpoint that accepts an upload, so replace it with adobe/s3mock: a small Apache-2 mock that pre-creates the bucket from an env var and accepts any credentials, which also removes the mc sidecar and the compose file.
Co-authored-by: Claude Fable 5.1 noreply@anthropic.com